Skip to content

Make combo cases & deaths robust to outages #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krivard opened this issue Oct 19, 2020 · 0 comments · Fixed by #343
Closed

Make combo cases & deaths robust to outages #330

krivard opened this issue Oct 19, 2020 · 0 comments · Fixed by #343

Comments

@krivard
Copy link
Contributor

krivard commented Oct 19, 2020

Currently, the combo cases and deaths signal quits if it can't get data from both jhu-csse and usa-facts. Instead, it should output whatever data it can find, and just log a warning.
krivard added a commit that referenced this issue Oct 20, 2020
@krivard
Make combo cases/deaths robust to source outages
9e46bc2 
- okay to return just one of the data frames if both aren't available
- do something sensible if neither one is available
- unit tests to verify all possible cases are handled appropriately

Fixes #330
@krivard krivard mentioned this issue Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make combo cases/deaths robust to source outages cmu-delphi/covidcast-indicators
1 participant
@krivard