-
Notifications
You must be signed in to change notification settings - Fork 16
Delphi_utils geomapper: update to fips 2020 population estimates #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like there are a whole pile of indicator tests that depend on the previous population mappings 😖 Those will need to be updated before we can merge. |
If there's a use case to applying 2020 data to pre Apr 1 (e.g. if someone who isn't doing an as_of analysis believes the 2020 data is more accurate than the 2019 estimates for the true population on January 1, 2021, they're free to use that), we could possibly kill two birds with one stone by changing geomapper so it can be init with a |
That's an interesting idea, but the tests are written with hard coded population values and functions that don't take a geomapper argument :/ |
Do you think we should then keep two directories of crosswalk files? Seems like a nice conservative approach, in case the update breaks something for users. |
…hi/covidcast-indicators into geomapper-fips-pop-2020
Gonna go ahead and just fix the tests for now and open issues for geomapper extensions to support 2019 and 2020 population estimates. We can think about coming up with a cutoff date for when we use the 2019 values vs the 2020 values for prop then. |
…hi/covidcast-indicators into geomapper-fips-pop-2020
Alright, looks like we squashed all the hardcoded prop tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
See #1319.
Changelog
Fixes