Skip to content

Review and prepare the deploy-jhu branch for production #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Jun 24, 2020
Merged

Review and prepare the deploy-jhu branch for production #101

merged 46 commits into from
Jun 24, 2020

Conversation

korlaxxalrok
Copy link
Contributor

  • Add a production params file
  • Add a new top level readme with deployment information for review

huisaddison and others added 30 commits June 2, 2020 18:34
@huisaddison
revert 7day smooth to wip_
685348e
update code for unassigned cases/deaths
44febee
update the dict for fake fips
849a32e
Set population for fake fips as NAN
f1f5cdd
update geo_id for megacounty
84bbfc6
update cache
339eac5
Cut 7-day avg signal name
8c538e3
Cut 7-day avg signal name
e2d8254
update naming for megacounty
030d38a
modify test cases for megacounty aggregation
f66b43e
delete whitespace
49be65d
delete whitespace
7ee404c
@jingjtang @krivard
Update jhu/tests/test_geo.py
25162d0 
Co-authored-by: krivard <[email protected]>
@jingjtang @krivard
Update jhu/tests/test_geo.py
0dae169 
Co-authored-by: krivard <[email protected]>
@jingjtang @krivard
Update jhu/tests/test_geo.py
64790fb 
Co-authored-by: krivard <[email protected]>
disable 7dav_ signals temporarily
435f63d
disable 7dav_ signal
d187ebc
cut 7day avg signal name
131b88b
delete df_mega for msa and hrr
003ac0c
revert test cases for msa and hrr
b911d8d
resolve conflicts
99c3860
resolve conflicts
eabe624
re-activate 7dav_ signal
b67269b
change naming for wip signal
50f9e95
resolve conflicts
cc203c6
@krivard
Merge pull request #68 from cmu-delphi/jingjing/jhu_with_unassigned
5931e21 
update code for unassigned cases/deaths
fixed errors in test_smooth
480ce66
fixed errors
72c2f73
recover smoothed signals
1ed824a
add .gitignore
9dc64f1
@korlaxxalrok korlaxxalrok requested a review from krivard June 22, 2020 20:50
@korlaxxalrok
Copy link
Contributor Author

@krivard I am setting this up to sort of push this into its final stages. I'll be adding a few bits and pieces to this, but your review of at least the readme for now will be much appreciated.

krivard
krivard reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the layout; fleshed out a few things.

@korlaxxalrok
Copy link
Contributor Author

@krivard Your (excellent!) suggestions are committed. Additionally, I've added a couple of small punctuation fixes, merged in the latest from run-jhu, and reverted to using a non-prod directory (the generically configured code-local `./receiving is a good fit) for csv output until we validate that everything works on production.

Can you review and accept if all looks ok?

krivard
krivard approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Only fly in the ointment is it looks like run-jhu was polluted with a GHT cache about two weeks ago, so the merged run-jhu PR brought the GHT files along with it. Up to you whether to fix that now or let it shake out when we purge the jhu cache; I'm fine either way.

@korlaxxalrok
Copy link
Contributor Author

Yeah... I'll merge for now, and then clean up after we are finished 👍

@korlaxxalrok korlaxxalrok merged commit 88bcc7d into deploy-jhu Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@korlaxxalrok @krivard @huisaddison @jingjtang