Skip to content

feat(breaking): do not throw because event handler was not found #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

feat(breaking): do not throw because event handler was not found #691

merged 2 commits into from
Mar 2, 2021

Conversation

hontas
Copy link
Contributor

@hontas hontas commented Mar 1, 2021

Summary

Idea from: #674 (comment)

Quote from @thymikee:

We actually don't the invokeEvent to be throwable. It supposed to be there as a debugging aid, but the original Testing Library don't have this behavior and here it actually complicates things a little more.

How about removing this behavior altogether in a separate PR and adjusting this one to keep the invokeEvent without the try/catch?

@hontas hontas mentioned this pull request Mar 1, 2021
Closed
@thymikee thymikee force-pushed the invoke-event-no-throw branch from fd10695 to 38f93ee Compare March 2, 2021 13:59
@thymikee thymikee changed the title Do not throw because event handler was not found feat(breaking): do not throw because event handler was not found Mar 2, 2021
@thymikee thymikee merged commit 8510d6d into callstack:master Mar 2, 2021
@thymikee
Copy link
Member

thymikee commented Mar 2, 2021

Thank you! We are not yet able to get rid of the parent.parent check, because it's already buggy and we'd contribute further to breaking a broken behavior (!sic). Need to figure out a proper solution first :)

@hontas
Copy link
Contributor Author

hontas commented Mar 3, 2021 •
edited
Loading

Happy to help. Thanks for the quick feedback 😀

@hontas hontas deleted the invoke-event-no-throw branch March 3, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hontas @thymikee