Make onPress more life-like #674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed the throwing behaviour from invokeEvent here: #691 |
|
Mind rebasing? :) |
hontas
force-pushed
the
user-like-tap-event
branch
from
6cafc39 to
5247b6a
Compare
hontas
force-pushed
the
user-like-tap-event
branch
from
5247b6a to
eeee8f7
Compare
|
@thymikee done :) |
7 tasks
|
Will this ever be merged? I need to be able to work with onFocus and I can't test it atm. |
|
@rarenatoe we'll take care of it, but have no timeline. In the meantime you can invoke |
|
Long term, shouldn't we try to to either create |
|
Closing in favour of #1119 which would be more organised approach that is also similar to RTL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking inspiration from user-event which tries to mimic the real event order when user interacts with an element.
Summary
fireEvent.presscurrently only invoke theonPress-handler, and this PR aim to make it more real-life-like by also invokingonPressIn,onPressOutandonFocusif possible (silently failing if there are no registered handlers).Also adding
fireEvent.longPressfor convenience.Test plan
Test added in fireEvent.test.js
Thoughts
One could discuss that this should be another method called
tapor something else that map closer to user intent than to event handler name. Looking forward to hear your feedback.