docs: Port 'How Should I Query?' guide from Native Testing Library #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
requested changes
Oct 12, 2020
There was a problem hiding this comment.
@pplytas Overall good idea 👍
I guess we could add short desc for a11yState + a11yValue. IMO there is no need for adding a11yStates as this got deprecated in RN, so is kind of compat query right now.
thymikee
reviewed
Oct 12, 2020
thymikee
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
@pplytas I've reworded this a big to follow https://testing-library.com/docs/guide-which-query#priority more. Also reordered a few queries (mainly moved hint and label a bit down) and added missing ones. Thanks!
@mdjastrzebski can you give it a go one more time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports the 'How Should I Query?' guide from this page: https://www.native-testing-library.com/docs/guide-queries.
The 'Manual Queries' section is not included since the
findAllmethod is not supported by the current version of the library.Fixes #512
Also these methods were not documented in the original guide, maybe we could add them:
ByA11yStates,ByAccessibilityStatesByA11yState,ByAccessibilityStateByA11Value,ByAccessibilityValueWdyt?
Test plan
Tested using
yarn startin thewebsite/directory.