Skip to content

Port guides from Native Testing Library #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thymikee opened this issue Aug 17, 2020 · 4 comments · Fixed by #555
Closed

Port guides from Native Testing Library #512

thymikee opened this issue Aug 17, 2020 · 4 comments · Fixed by #555
Labels
docs good first issue Good for newcomers

Comments

@thymikee
Copy link
Member

thymikee commented Aug 17, 2020

Describe the Feature

Port the most relevant guides from this page: https://www.native-testing-library.com/docs/guide-queries.
I'm not sure if we need them all, so feel free to pick the best ones :)

Possible Implementations

We already have a section for Guides in the sidebar, so they could be linked there.
We can also link to the official docs: https://testing-library.com/docs/guide-which-query but there are slight differences in APIs

@thymikee thymikee added docs good first issue Good for newcomers labels Aug 17, 2020
@pplytas
Copy link
Contributor

pplytas commented Sep 27, 2020

Hi @thymikee, there aren't many guides in this page: https://www.native-testing-library.com/docs/guide-queries Just a brief explanation of the getBy methods and a couple of paragraphs for Manual Queries.

Did you mean this page as well: https://www.native-testing-library.com/docs/guide-disappearance and the examples below (i.e Context, Input Event, Intl, Navigation, Redux, Update Props)?

@thymikee
Copy link
Member Author

I meant "How Should I Query?" specifically. Would be great to add more docs though! :)

@pplytas
Copy link
Contributor

pplytas commented Sep 27, 2020

Great I'm preparing a PR for this. Should the 'Manual Queries' section be included as well, since the library doesn't support the findAll method mentioned there?

@thymikee
Copy link
Member Author

Yup, skip findAll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs good first issue Good for newcomers
Projects
None yet
2 participants