Skip to content

feat(breaking): rename ByPlaceholder to ByPlaceholderText #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

thymikee
Copy link
Member

Summary

Renames ByPlaceholder to ByPlaceholderText. Closes #447

Test plan

image

@thymikee thymikee requested a review from mdjastrzebski July 24, 2020 19:04
@thymikee thymikee force-pushed the feat/rename-placeholder branch from 15c4e10 to aac2d94 Compare July 24, 2020 19:26
Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thymikee thymikee added this to the 7.x milestone Jul 24, 2020
@thymikee thymikee changed the base branch from master to 7.x July 24, 2020 20:52
@thymikee thymikee merged commit d18bf88 into 7.x Jul 24, 2020
@thymikee thymikee deleted the feat/rename-placeholder branch July 24, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: [TL migration] rename getByPlaceholder to getByPlaceholderText (or provide an alias)
2 participants