Skip to content

chore: [TL migration] rename getByPlaceholder to getByPlaceholderText (or provide an alias) #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdjastrzebski opened this issue Jul 20, 2020 · 2 comments · Fixed by #455
Closed

chore: [TL migration] rename getByPlaceholder to getByPlaceholderText (or provide an alias) #447

mdjastrzebski opened this issue Jul 20, 2020 · 2 comments · Fixed by #455
Labels
compat: testing-library good first issue Good for newcomers
Milestone
7.x

Comments

@mdjastrzebski
Copy link
Member

Describe the Feature

Currently we have getByPlaceholder (and related queries). However, both RTL and deprecated TL/RN use getByPlaceholderText.

This seems to be consistent with other RTL, TL/RN names likes getByLabelText, getByHintText, etc.

Possible Implementations

  1. Rename getByPlaceholder -> getByPlaceholderText
  2. Add alias for getByPlaceholderText

Selected option should be mentioned in the migration guide.

My preferred option would be 1 (rename), as it would keep things simple & consitent.

Related Issues

This is part of migration to official TL repo.

CC: @thymikee @Esemesek @cross19xx
@mdjastrzebski mdjastrzebski changed the title chore: TL migration rename getByPlaceholder to getByPlaceholderText (or provide an alias) chore: [TL migration] rename getByPlaceholder to getByPlaceholderText (or provide an alias) Jul 20, 2020
@thymikee
Copy link
Member

I'm in for option 1, the change is easy enough to migrate without too much effort.

@vanGalilea vanGalilea mentioned this issue Jul 21, 2020
Closed
@thymikee thymikee added this to the 7.x milestone Jul 24, 2020
@thymikee thymikee mentioned this issue Jul 24, 2020
Merged
@thymikee
Copy link
Member

Closed via #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compat: testing-library good first issue Good for newcomers
Projects
None yet
Milestone
7.x
Development

Successfully merging a pull request may close this issue.

feat(breaking): rename ByPlaceholder to ByPlaceholderText callstack/react-native-testing-library
2 participants
@thymikee @mdjastrzebski