-
Notifications
You must be signed in to change notification settings - Fork 273
Move to @testing-library/react-native
🎉
#442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I could help. |
Awesome @balavishnuvj! Let me know if you need any help. So far, in terms of differences between the libs, I'm only aware of the "disabled" property being specially handled by the second library. Is there anything else? |
@thymikee I don't understand in and out of the library as of now. Would need your help. Also, this would one of my first open-source contributions. |
I am working on migrating a project from The first difference I noticed was that Second, there is a difference in querying by accessibility labels between the two libraries. Hope this helps! |
I'm happy to accept a PR that aliases |
I would be happy to take on this PR, but it would be my first time contributing to the project. To clarify, we would alias any queries ending in |
Great! No warning is needed, |
@thymikee Just put a PR up for it now. I think I see what you mean, hopefully this was what you were thinking. 😄 |
Hi all, Just migrated my real world examples repo, was pretty straightforward here are the diffs: vanGalilea/react-native-testing@66f8fd3 vanGalilea/react-native-testing@364a4b4 Summary of all changes in my repo:
|
Thank you very much @vanGalilea! |
v6 of @testing-library/react-native was just published. So when we publish this repo as the main package it will need to be version 7 |
You mean that the props 'disabled' is not available on TocuhableOpacity as a test instance? |
Hey all, I've added a migration guide PR: #456. Please review, let me know if I missed anything and if there are any readability improvements we can make :) |
Anyone have interest in taking over https://github.com/testing-library/jest-native as part of this? |
I'm happy to watch |
We're in the process of completely replacing https://github.com/testing-library/native-testing-library with this repo. Which means renaming
react-native-testing-library
to@testing-library/react-native
.Would anyone be interested in writing a migration guide?
EDIT:
Migration guide: https://callstack.github.io/react-native-testing-library/docs/migration-v7
The text was updated successfully, but these errors were encountered: