-
Notifications
You must be signed in to change notification settings - Fork 273
feature: configure API from DTL #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
416a632
feature: basic configure api
mdjastrzebski 2c86ad1
test: config module
mdjastrzebski ce11d48
refactor: apply to waitFor with tests
mdjastrzebski 9d8eee9
docs:
mdjastrzebski 0195e00
chore: flow types
mdjastrzebski 0daa8a8
docs: tweaks
mdjastrzebski 701426d
fix: lint
mdjastrzebski 7a05fd8
refactor: restore removed tests
mdjastrzebski 9d24cc0
refactor: self code review
mdjastrzebski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import { getConfig, configure, resetToDefaults } from '../config'; | ||
|
||
beforeEach(() => { | ||
resetToDefaults(); | ||
}); | ||
|
||
test('getConfig() returns existing configuration', () => { | ||
expect(getConfig().asyncUtilTimeout).toEqual(1000); | ||
}); | ||
|
||
test('configure() overrides existing config values', () => { | ||
configure({ asyncUtilTimeout: 5000 }); | ||
expect(getConfig().asyncUtilTimeout).toEqual(5000); | ||
}); | ||
|
||
test('resetToDefaults() resets config to defaults', () => { | ||
configure({ asyncUtilTimeout: 5000 }); | ||
expect(getConfig().asyncUtilTimeout).toEqual(5000); | ||
|
||
resetToDefaults(); | ||
expect(getConfig().asyncUtilTimeout).toEqual(1000); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
export type Config = { | ||
/** Default timeout, in ms, for `waitFor` and `findBy*` queries. */ | ||
asyncUtilTimeout: number; | ||
}; | ||
|
||
const defaultConfig: Config = { | ||
asyncUtilTimeout: 1000, | ||
}; | ||
|
||
let config = { | ||
...defaultConfig, | ||
}; | ||
|
||
export function configure(options: Partial<Config>) { | ||
config = { | ||
...config, | ||
...options, | ||
}; | ||
} | ||
|
||
export function resetToDefaults() { | ||
config = defaultConfig; | ||
} | ||
|
||
export function getConfig() { | ||
return config; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
resetToDefaults
exported from DTL? Couldn't find it on their docsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's not, only
configure
is, but I think it's good to have that for testinging convenience. Wdyt?