Skip to content

feature: configure API from DTL #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 27, 2022
Merged

feature: configure API from DTL #1141

merged 9 commits into from
Sep 27, 2022

Conversation

mdjastrzebski
Copy link
Member

Summary

Implement configure API based on similar API in DTL.

Added initial option for asyncWaitTimeout.

Test plan

  • Added tests for config module functions
  • Added tests for waitFor consuming asyncWaitTimeout option

@mdjastrzebski mdjastrzebski mentioned this pull request Sep 27, 2022
Closed
@mdjastrzebski mdjastrzebski merged commit 932c547 into main Sep 27, 2022
@mdjastrzebski mdjastrzebski deleted the feature/configure-api branch September 27, 2022 14:18
thymikee
thymikee approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also implement defaultHidden, right? Looks good though

src/pure.ts

export { act };
export { cleanup };
export { configure, resetToDefaults } from './config';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is resetToDefaults exported from DTL? Couldn't find it on their docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not, only configure is, but I think it's good to have that for testinging convenience. Wdyt?

@mdjastrzebski
Copy link
Member Author

re defaultHidden: we first need to merge #1064, as it contains the hidden query options, and afaik defaultHidden is just the default value of that option.

@thymikee
Copy link
Member

re defaultHidden: we first need to merge #1064, as it contains the hidden query options, and afaik defaultHidden is just the default value of that option.

Huh, it's opened for so long I thought it's already in 🙈

@mdjastrzebski
Copy link
Member Author

It should be much easier done now when we have isInaccessible #1128 , which is the core logic behind hidden flag.

@thymikee
Copy link
Member

Definitely! And please don't get me wrong, I'm not expecting to rush things here :)

@mdjastrzebski mdjastrzebski mentioned this pull request Sep 30, 2022
Closed
@AugustinLF AugustinLF mentioned this pull request Oct 9, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@AugustinLF AugustinLF AugustinLF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdjastrzebski @thymikee @AugustinLF