Mark the native property as non-enumerable. Closes #945 #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brianc Tests pass now :) |
|
Very nice! I think this probably could break backwards compatibility in some weird edge cases - what do you think? I think it should be a major version bump. |
|
Not sure I can think of any cases right now - Would users every purposefully enumerate the object? The only cases I can think of are when the pg object is cloned as a child of something else |
|
Yeah sorry for dropping the ball on this one... I've been busy w/ life stuff. I see there is this pr as well. Do you want me to unify the changes between these two PRs & submit a new PR that does both of these in combo? I think both changes make sense & fix different parts of the issue. |
|
@brianc Yeah that would be nice! :) |
|
I believe this is fixed in 5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.