pg.native – return null if pg-native is missing

[langpavel]

require('pg').native will be null and report error once to stdout when pg-native is missing.

Fixes #838

[langpavel]

May be solution for #945 too. @janmeier what you think?

[janmeier]

It would solve the biggest part of the issue, crashing the app, but would still mean that an error message is logged to the console, without the user knowing why - "But I'm not accessing the native property directly, why do I see this message"

[langpavel]

@janmeier Because something (babel in this case?) accessing native property.
Message can be removed and null returned, but this is not good solution.

Message is shown only once when native property is accessed first time.

Any suggestions welcomed!

[anthonyjspoerl]

Is there a better solution for this being worked on? I am not using pg-native and am running into this issue in CI. I would prefer this solution over having to unnecessarily configure pg-native in CI.

[langpavel]

@anthonyjspoerl There is PR #952 which hide property from Babel by making property nonenumerable.
I'm not sure how tools like eslint-plugin-import cope with hidden property, so return null and report warning when property is very firstly accessed is correct way.
I can add process.env.… switch to suppress warning, but this is unnecesary by my opinion.
Best solution should be instruct tooling to not touch this property.

[brianc]

Dang sorry I missed this! I've been in the weeds with other things in my life for a while, getting out now finally. 💃

I'll go through the PRs and see which ones break backwards compatibility, clump them up, merge them, and push a new major version. I consider this a backwards break since someone somewhere might be depending weirdly on it throwing an exception.

[vitaly-t]

All libraries that rely on node-postgres to detect and throw when pg-native isn't found would have to be modified, if we allow this change.

At the moment, the exception thrown is the only pointer that pg-native is missing as a dependency.

In all, this would be a breaking change (not that I'm against it) ;)

[gaastonsr]

Bump!

Using knex.js and Node 6 and receiving error.

Advice for a patch in the mean time?

[langpavel]

I think this is good choice. Thanks!