Add support for eslint v9 #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint v9 requires `meta.schema` to be present if a rule accepts options.
This allows easier consumption when using flat configs, similar to how this is done in `eslint-plugin-jsx-a11y`.
leiit
force-pushed
the
feat/eslint-9-support
branch
from
66d24d1 to
8797544
Compare
leiit
commented
Jul 10, 2024
| @@ -39,205 +41,219 @@ module.exports = { | |||
| scope: makeRule('scope'), | |||
| 'tabindex-no-positive': makeRule('tabindex-no-positive'), | |||
| }, | |||
| configs: { | |||
There was a problem hiding this comment.
This is unchanged, just moved to the top level as its reused for the flat configs. Easier to check the diff having "hide whitespace" toggled.
brendanmorrell
approved these changes
Jul 11, 2024
|
beautiful! merged and will be publishing shortly |
|
fixed in version 2.1.35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62.
Seems that the only reason the current version fails to run using eslint v9 is due to it now enforcing
meta.schemato be set for rules that accept options. See https://eslint.org/docs/latest/use/migrate-to-9.0.0#meta-schema-required:Since all the exposed rules are actually coming from
eslint-plugin-jsx-a11y, which has this metadata available already, simply passing the metadata from there seems to do it.Additionally, this exposes
flatConfigs.recommended&flatConfigs.strictfor easier usage, similar to how the main jsx-a11y plugin does this.