Skip to content

Support for Eslint v9 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hiteto218 opened this issue Apr 8, 2024 · 3 comments · Fixed by #66
Closed

Support for Eslint v9 #62

hiteto218 opened this issue Apr 8, 2024 · 3 comments · Fixed by #66

Comments

@hiteto218
Copy link

Hello,
It seems that Eslint v9 has been newly released.
However, when I execute it with v9, I encountered the following error:

Error: Key "rules": Key "styled-components-a11y/interactive-supports-focus":
Value [{"tabbable":["button","checkbox","link","searchbox","spinbutton","switch","textbox"]}] should NOT have more than 0 items.

Do you have any plans to support v9?

@brendanmorrell
Copy link
Owner

brendanmorrell commented Apr 11, 2024 via email

@brendanmorrell
Copy link
Owner

so, finally getting around to looking at this. it looks like v9 of eslint involves pretty sweeping changes, to the point that most plugins do not currently support it. from what i see, eslint-plugin-jsx-a11y falls into that category, and does not yet support v9.  this plug in is built on top of eslint-plugin-jsx-a11y, and as such, I don't think there is any way for me to support v9 at this point. if i am wrong about that, let me know and i can reopen this. if so, it would also help if you could provide a code sandbox or a repo using eslint v9 which showcases a component correctly getting a jsx-a11y error (such as an onClick on a div showing the 'jsx-a11y/click-events-have-key-events' error so i can verify everything is working with that, and then i can add eslint-plugin-styled-components-a11y and work backward from there until a styled component produces the same error)

@brendanmorrell
Copy link
Owner

fixed in version 2.1.35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants