Skip to content

Packaging support on Alpine Linux #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Packaging support on Alpine Linux #131

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1ec460
Packaging support on Alpine Linux
specious Nov 18, 2021
482e8e8
Check system architecture using a standard utility and only where needed
specious Nov 19, 2021
4cdb75b
Use long-form flags in packager script
specious Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions packaging/packager
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ done
set -- "${POSITIONAL[@]}" # restore positional parameters

PKG_BIN_PATH=$1
architecture=$(arch)

if [ ! -f "$PKG_BIN_PATH" ]; then
echo "$PKG_BIN_PATH" - No such file.;
Expand All @@ -56,26 +55,41 @@ if ! type zip > /dev/null 2>&1; then
echo "zip utility is not found. Please install it and re-run this script"
exit 1
fi
function package_libc_via_pacman {

function pluck_so_files() {
sed -E '/\.so$|\.so\.[0-9]+$/!d'
}

function package_libc_alpine() {
if grep -F "Alpine Linux" < /etc/os-release > /dev/null; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the long form of the command line option, please.
grep --fixed-strings

Copy link
Contributor Author

@specious specious Nov 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcomagdy, now it doesn't build on Alpine, because busybox knows grep -F but it doesn't know it as --fixed-strings.

if type apk > /dev/null 2>&1; then
apk info -L musl 2>/dev/null | pluck_so_files | sed 's/^/\//'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here if applicable. If not add a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem.

fi
fi
}

function package_libc_pacman() {
if grep --extended-regexp "Arch Linux|Manjaro Linux" < /etc/os-release > /dev/null 2>&1; then
if type pacman > /dev/null 2>&1; then
pacman --query --list --quiet glibc | sed -E '/\.so$|\.so\.[0-9]+$/!d'
pacman --query --list --quiet glibc | pluck_so_files
fi
fi
}

function package_libc_via_dpkg() {
function package_libc_dpkg() {
if type dpkg-query > /dev/null 2>&1; then
if [[ $(dpkg-query --listfiles libc6 | wc -l) -gt 0 ]]; then
dpkg-query --listfiles libc6 | sed -E '/\.so$|\.so\.[0-9]+$/!d'
dpkg-query --listfiles libc6 | pluck_so_files
fi
fi
}

function package_libc_via_rpm() {
function package_libc_rpm() {
arch=$(uname -m)

if type rpm > /dev/null 2>&1; then
if [[ $(rpm --query --list glibc.$architecture | wc -l) -gt 1 ]]; then
rpm --query --list glibc.$architecture | sed -E '/\.so$|\.so\.[0-9]+$/!d'
if [[ $(rpm --query --list glibc.$arch | wc -l) -gt 1 ]]; then
rpm --query --list glibc.$arch | pluck_so_files
fi
fi
}
Expand All @@ -99,9 +113,10 @@ PKG_LD=""

list=$(ldd "$PKG_BIN_PATH" | awk '{print $(NF-1)}')
libc_libs=()
libc_libs+=($(package_libc_via_dpkg))
libc_libs+=($(package_libc_via_rpm))
libc_libs+=($(package_libc_via_pacman))
libc_libs+=($(package_libc_dpkg))
libc_libs+=($(package_libc_rpm))
libc_libs+=($(package_libc_pacman))
libc_libs+=($(package_libc_alpine))

mkdir -p "$PKG_DIR/bin" "$PKG_DIR/lib"

Expand Down