-
Notifications
You must be signed in to change notification settings - Fork 94
Packaging support on Alpine Linux #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any chance someone could take a quick look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@bmoffatt PTAL.
packaging/packager
Outdated
} | ||
|
||
function package_libc_alpine() { | ||
if grep -F "Alpine Linux" < /etc/os-release > /dev/null; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the long form of the command line option, please.
grep --fixed-strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcomagdy, now it doesn't build on Alpine, because busybox knows grep -F
but it doesn't know it as --fixed-strings
.
packaging/packager
Outdated
function package_libc_alpine() { | ||
if grep -F "Alpine Linux" < /etc/os-release > /dev/null; then | ||
if type apk > /dev/null 2>&1; then | ||
apk info -L musl 2>/dev/null | pluck_so_files | sed 's/^/\//' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here if applicable. If not add a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem.
Added packaging support on Alpine Linux with the native musl C library.
Building inside an Alpine Docker container looks like:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.