-
Notifications
You must be signed in to change notification settings - Fork 63
feat!: Remove AWS SDK V2 Dependency #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: The AWS Encryption SDK for JavaScript: - does not supports the AWS SDK for JavaScript V2 - requires the AWS SDK for JavaScript V3's kms-client (if using the KMS Keyring).
BREAKING CHANGE: This library no longer tests against nor supports NodeJS 12 or 14.
Addresses feedback in aws#1177: aws#1177 (review)
I do not know why, but the CB It does not run Huh... it's hanging on my local as well... The question then is if it's learna or verdaccio that is hanging... Huh... running the commands in So something is up with the actual JS in Fudge. Update: I resolved this by setting a time out for the lerna process and having it call process.exit() on close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
process.exit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that this is required because you have added a timeout
.
That timeout is likely implemented with setTimeout
.
This means when this is executed there is an event in the background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... it was hanging before I added the timeout.
But I guess I could check to see if just exit fixes the hang, with out the time out.
… into tony-drop-v2-node-14
Issue #, if available: #1100, #922, #865, #1178, #1177
Description of changes:
In CodeBuild Builds:
BREAKING CHANGE:
The AWS Encryption SDK for JavaScript:
Note: @seebees I had to merge #1177 and #1178 to get CodeBuild to pass.
I think the new package-lock only supports Node >= 16,
so I needed to drop the Node 14 tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: