Skip to content

KmsKeyringNode dependency on aws-sdk resulting in Deprecation WARNings #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RalphBragg opened this issue Feb 28, 2023 · 9 comments
Closed
Labels
high priority High priority PR that a lot of things depend on release blocker This issue must be fixed before the next release

Comments

@RalphBragg
Copy link

Problem:

This library is still dependent on the full aws-sdk despite numerous tickets and requests being raised for its removal by this community (mainly for lambda use cases). I believe it is now the cause of the WARN messages being raised in any package and service that is using the node crypto library. Please advise on what the intended solution is for this please and the timelines. Happy to migrate to another capability if there's a migration guide available

(node:92870) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.
Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
at emitWarning (/Users/REDACTED/node_modules/aws-sdk/lib/maintenance_mode_message.js:21:13)
at Timeout._onTimeout (/Users/REDACTED/node_modules/aws-sdk/lib/maintenance_mode_message.js:29:5)

Solution:

Use something other than the full aws-sdk library

Out of scope:

Is there anything the solution will intentionally NOT address?

@JohnBrown0126
Copy link

Can we get some eyes on this

@defy93
Copy link

defy93 commented Mar 16, 2023

+1 this issue as well

@texastony
Copy link
Contributor

@RalphBragg (+ @JohnBrown0126 , @defy93 , and others),

We are aware that the AWS SDK for JavaScript V2 is going into maintenance.
Recently, we released a new minor version of the AWS Encryption SDK for JavaScript (ESDK-JS),
3.2.0, which featured support for the AWS SDK for JavaScript V3.

We did not remove the AWS SDK V2 dependency, as we did not want break any current customers,
who may have relied on the V2 SDK existing in the ESDK-JS.

We will release the ESDK-JS that only relies on the AWS SDK V3 in a new major version.

(Leaving this issue open, pending the new Major Version release described above)

Much Obliged,
AWS Crypto Tools

@texastony texastony added high priority High priority PR that a lot of things depend on release blocker This issue must be fixed before the next release labels Mar 16, 2023
@revmischa
Copy link

revmischa commented Mar 21, 2023

Will be very nice to get rid of the v2 dependency because it adds a considerable amount of JS to my lambda bundle on node 18.

image

@RalphBragg
Copy link
Author

@RalphBragg (+ @JohnBrown0126 , @defy93 , and others),

We are aware that the AWS SDK for JavaScript V2 is going into maintenance. Recently, we released a new minor version of the AWS Encryption SDK for JavaScript (ESDK-JS), 3.2.0, which featured support for the AWS SDK for JavaScript V3.

We did not remove the AWS SDK V2 dependency, as we did not want break any current customers, who may have relied on the V2 SDK existing in the ESDK-JS.

We will release the ESDK-JS that only relies on the AWS SDK V3 in a new major version.

(Leaving this issue open, pending the new Major Version release described above)

Much Obliged, AWS Crypto Tools

Is there are ETA on this?

@texastony
Copy link
Contributor

@RalphBragg,
This release is on our roadmap.
But, as a rule, we do not publish dates.

@frsechet
Copy link

Now that #1180 was merged, which fixes that, any chance to get a new version published, or an approximate ETA for that (days, weeks, months, years)?

@NimmLor
Copy link

NimmLor commented Jul 18, 2023

@frsechet
Version 4.0.0 just got released.

@josecorella
Copy link
Contributor

Hello @RalphBragg,

Major Version 4.0.0 of the AWS ESDK for JS has been released. This major version should address the problems you outline on this issue. Please let us know if you have any questions.

AWS Crypto Tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High priority PR that a lot of things depend on release blocker This issue must be fixed before the next release
Projects
None yet
Development

No branches or pull requests

8 participants