Skip to content

@aws-crypto/kms-keyring-node module aws-sdk as dependency #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucasvieirasilva opened this issue Mar 7, 2022 · 1 comment
Closed

@aws-crypto/kms-keyring-node module aws-sdk as dependency #865

lucasvieirasilva opened this issue Mar 7, 2022 · 1 comment

Comments

@lucasvieirasilva
Copy link

Problem:

Currently, the module @aws-crypto/kms-keyring-node uses the AWS SDK as a dependency and that makes the bundle package big for AWS Lambdas, I think this SDK should cover AWS Lambda scenarios as well.

Solution:

The aws-sdk dependency should be moved to peerDependencies in the package.json, making it possible for the clients to choose to use the AWS SDK as devDependency or explicit dependency.

Related issue
This was referenced Jun 29, 2023
Closed
Merged
@josecorella
Copy link
Contributor

Hello @lucasvieirasilva,

Major Version 4.0.0 of the AWS ESDK for JS has been released. This major version should address the problems you outline on this issue. Please let us know if you have any questions.
AWS Crypto Tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucasvieirasilva @josecorella