Skip to content

KmsKeyringNode dependency on aws-sdk #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RalphBragg opened this issue May 7, 2021 · 5 comments
Closed

KmsKeyringNode dependency on aws-sdk #600

RalphBragg opened this issue May 7, 2021 · 5 comments

Comments

@RalphBragg
Copy link

Hi,

This is a question really, are there any plans to address the requirement for the AWS Key Ring Node to have a dependency on the entire aws-sdk? It blows the package sizes significantly and i was wondering if this is likely to be addressed at all?

Kind Regards,

@medievallondoners
Copy link

+1

This is especially problematic when packaging for Lambda - when normally including the AWS-SDK in your uploaded package is not required at all. But for my functions that use this crypto library, it is impossible to remove the SDK when preparing for Lambda because of this persistent dependency.

PLEASE FIX THIS.

@seebees
Copy link
Contributor

seebees commented Dec 9, 2021

As a workaround, you can delete the AWS SDK from the AWS Lambda zip.
I understand that this is not a great long term solution.

A tool that could remove this dependance for any AWS Lambda customer,
not only ESDK customers seems like a good feature ask for the SDK.

@RalphBragg
Copy link
Author

This has just about mean using AWS lambda useless for our usecases. This is very poor.

@GlennyDC
Copy link

The package aws-sdk is no longer part of the Lambda runtime when using Node.js 18.x which means that if you want to use this library you have to include it yourself.

@RalphBragg
Copy link
Author

RalphBragg commented Feb 28, 2023

So i believe this is now also causing all of the warnings about AWS v2 API being deprecated? Can anyone confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants