Skip to content

Issue 66: Changed the RootNode constructor so that the ObjectMapper i… #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

msailes
Copy link
Collaborator

@msailes msailes commented Feb 8, 2021

Issue #, if available:
#66

Description of changes:
Changed the RootNode constructor so that the ObjectMapper is no longer instantiated on each new RootNode.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…s no longer instantiated on each new RootNode.
Copy link
Member

@jaredcnance jaredcnance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Mark! LGTM.

@jaredcnance jaredcnance requested a review from yaozhaoy February 10, 2021 02:30
@msailes
Copy link
Collaborator Author

msailes commented Feb 10, 2021

You're welcome, we'd like to take this change into Lambda Powertools for Java. When it's released.

@jaredcnance jaredcnance merged commit d434136 into awslabs:master Feb 10, 2021
@msailes msailes deleted the objectmapper-performance branch February 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants