Skip to content

Repeated Construction of ObjectMapper hurting performance #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonnekaunisto opened this issue Feb 7, 2021 · 1 comment
Closed

Repeated Construction of ObjectMapper hurting performance #66

jonnekaunisto opened this issue Feb 7, 2021 · 1 comment

Comments

@jonnekaunisto
Copy link

I have an application that is publishing a lot of metrics.

Through profiling I was able to see that around 3% of CPU usage was going into repeatedly constructing ObjectMapper in the EMF library.

I narrowed it down to this constructor:

aws-embedded-metrics-java/src/main/java/software/amazon/cloudwatchlogs/emf/model/RootNode.java

Line 49 in 4ccacf6

objectMapper = new ObjectMapper();

Is it possible to make the ObjectMapper static?
@msailes msailes mentioned this issue Feb 8, 2021
Merged
@jaredcnance
Copy link
Member

Closed by #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnekaunisto @jaredcnance