This repository was archived by the owner on May 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 101
Add gunicorn timeout #220
Merged
Merged
Add gunicorn timeout #220
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
596a03b
Add env var that will manage GUnicorn setup timeout.
matherit 54b8e82
Ensure env var is treated as innt.
matherit 739c82a
Update readme to include new env var section and update TOC.
matherit 6e99c4c
Add SAGEMAKER_GUNICORN_LOGLEVEL description to readme.
matherit 984455c
expose gunicorn logging (#219)
mseth10 45b0373
Add in SAGEMAKER_GUNICORN_TIMEOUT_SECONDS.
matherit 5cabd4c
Update readme with PR feedback.
matherit d71c040
Remove extra argument in format.
matherit b074e61
Merge branch 'master' of github.com:matherit/sagemaker-tensorflow-ser…
matherit 3683199
Remove setup timeout.
matherit 188095a
Make readme links clickable.
matherit 260a8c5
Remove boiler plate statements and instead link in descriptive commen…
matherit f50b1b4
Update capitalization of Gunicorn.
matherit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see if you can make it a clickable link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know how you feel about my current readme. It removes the
please refer to
language, but I felt that would just be unnecessary "boilerplate" language.I'm open to swapping it back if we feel that having that was actually better though.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I noticed that you are using
GUnicorn
, but usually people writeGunicorn
unless they split the word likeGreen Unicorn
. Let's move toGunicorn
to make it consistent ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed.