Add gunicorn timeout #220
Add gunicorn timeout #220
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…ving-container into add-gunicorn-timeout
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
README.md
Outdated
| ```bash | ||
| # Configures the logging level for GUnicorn. | ||
| # When looking to set this environment variable, please refer to: | ||
| # https://docs.gunicorn.org/en/stable/settings.html#loglevel |
There was a problem hiding this comment.
Please see if you can make it a clickable link.
There was a problem hiding this comment.
Let me know how you feel about my current readme. It removes the please refer to language, but I felt that would just be unnecessary "boilerplate" language.
I'm open to swapping it back if we feel that having that was actually better though.
Thanks!
There was a problem hiding this comment.
This is okay with me.
There was a problem hiding this comment.
nit: I noticed that you are using GUnicorn, but usually people write Gunicorn unless they split the word like Green Unicorn. Let's move to Gunicorn to make it consistent ?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available:
Description of changes:
Makes the GUnicorn startup timeout configurable via an environment variable. I also updated the readme to include a section that details configurable env vars like this one that do not fit under current sections.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.