Skip to content

Append retry id to default Airflow job name to avoid naming collision in retry #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Append retry id to default Airflow job name to avoid naming collision in retry #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19fa3e5
Append retry id to default Airflow job name to avoid naming collision…
yangaws Dec 14, 2018
b42ae56
Merge branch 'master' into airflow_retry
yangaws Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
CHANGELOG
=========

1.16.3
======
1.16.3.dev
==========

* bug-fix: Append retry id to default Airflow job name to avoid name collisions in retry
* bug-fix: Local Mode: No longer requires s3 permissions to run local entry point file

1.16.2
Expand Down
9 changes: 5 additions & 4 deletions src/sagemaker/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@
import six


AIRFLOW_TIME_MACRO = "{{ execution_date.strftime('%Y-%m-%d-%H-%M-%S') }}"
AIRFLOW_TIME_MACRO_LEN = 19
AIRFLOW_TIME_MACRO_SHORT = "{{ execution_date.strftime('%y%m%d-%H%M') }}"
AIRFLOW_TIME_MACRO_SHORT_LEN = 11
AIRFLOW_RETRY_MACRO = "{{ task_instance.try_number }}"
AIRFLOW_TIME_MACRO = "{{ execution_date.strftime('%Y-%m-%d-%H-%M-%S') }}" + "-{}".format(AIRFLOW_RETRY_MACRO)
AIRFLOW_TIME_MACRO_LEN = 22
AIRFLOW_TIME_MACRO_SHORT = "{{ execution_date.strftime('%y%m%d-%H%M') }}" + "-{}".format(AIRFLOW_RETRY_MACRO)
AIRFLOW_TIME_MACRO_SHORT_LEN = 14


# Use the base name of the image as the job name if the user doesn't give us one
Expand Down
Loading