Skip to content

Append retry id to default Airflow job name to avoid naming collision in retry #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Dec 14, 2018

… in retry

Issue #, if available:

Description of changes:
Now during Airflow operator retry, the job names (training/model/tuning/transform/endpoint-config/endpoint) are same as before. So there will be naming collision and all retries will fail for job already existed. This PR appends a retry id to the default job names. Then different attempt of operator will have different job_name which avoids failure due to naming collisions.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested a review from laurenyu December 14, 2018 20:03
@yangaws yangaws merged commit 2ad6c1d into aws:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants