Skip to content

change: merge method inputs with class inputs #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

benieric
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Small change in behavior for managing inputs in ModelTrainer.
  • merge method inputs with class inputs instead of override

Previous Behavior:

model_trainer = ModelTrainer(input_data_config=[model_input]) # user provides model channel 

model_trainer.train(input_data_config[train_input]) # User provides train input, and would override the model input when calling train

New Behavior:

model_trainer = ModelTrainer(input_data_config=[model_input]) # user provides model channel 

model_trainer.train(input_data_config[train_input]) # method and class inputs merged when calling API

Testing done:

  • Unit test

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric benieric requested a review from a team as a code owner May 21, 2025 19:00
@benieric benieric requested a review from nileshvd May 21, 2025 19:00
@benieric benieric merged commit 3f484d7 into aws:master May 22, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants