Skip to content

feature:support custom workflow deployment in ModelBuilder using SMD image. #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pravali96
Copy link
Collaborator

@pravali96 pravali96 commented Apr 23, 2025

Issue #, if available:
support custom workflow deployment in ModelBuilder using SMD inference image.

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pravali96 pravali96 marked this pull request as ready for review April 23, 2025 18:24
@pravali96 pravali96 requested a review from a team as a code owner April 23, 2025 18:24
@pravali96 pravali96 requested review from Aditi2424 and cj-zhang April 23, 2025 18:24
@cj-zhang
Copy link
Collaborator

LGTM; I increased the g5.24xl limits for the failing integ test.

cj-zhang and others added 4 commits April 23, 2025 22:47
…image. (aws#1661)

* feature:support custom workflow deployment in ModelBuilder using SMD inference image.

* Rename test case and pass session.

* Address PR comments.

* Tweak resource cleanup logic in integ test.

* Fixing CodeBuild integ test failures.

* Renamed integ test.

* Remove unused integ test, restore once GA.

---------

Co-authored-by: Joseph Zhang <[email protected]>
* Remove property@ decorator from ABC definition.

* Cache client as instance attribute in @Property.

* Fix flake8 issue.

---------

Co-authored-by: Joseph Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants