Skip to content

Commit b57b292

Browse files
author
Pravali Uppugunduri
committed
Fix Alabtross Inference component tests
1 parent e66e77e commit b57b292

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/sagemaker/serve/builder/model_builder.py

-1
Original file line numberDiff line numberDiff line change
@@ -1983,7 +1983,6 @@ def deploy(
19831983
"""
19841984
if not hasattr(self, "built_model") and not hasattr(self, "_deployables"):
19851985
raise ValueError("Model needs to be built before deploying")
1986-
endpoint_name = unique_name_from_base("endpoint-name")
19871986
if not update_endpoint:
19881987
endpoint_name = unique_name_from_base(endpoint_name)
19891988

tests/integ/sagemaker/serve/test_serve_model_builder_inference_component_happy.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040

4141
LLAMA_2_7B_JS_ID = "meta-textgeneration-llama-2-7b"
4242
LLAMA_IC_NAME = "llama2-mb-ic"
43+
INSTANCE_TYPE = "ml.g5.24xlarge"
4344

4445

4546
@pytest.fixture
@@ -65,6 +66,7 @@ def test_model_builder_ic_sagemaker_endpoint(
6566
caught_ex = None
6667

6768
model_builder_llama_inference_component.sagemaker_session = sagemaker_session
69+
model_builder_llama_inference_component.instance_type = INSTANCE_TYPE
6870

6971
model_builder_llama_inference_component.inference_component_name = unique_name_from_base(
7072
LLAMA_IC_NAME
@@ -88,7 +90,7 @@ def test_model_builder_ic_sagemaker_endpoint(
8890
logger.info("Deploying and predicting in SAGEMAKER_ENDPOINT mode...")
8991
endpoint_name = "llama-ic-endpoint-name"
9092
predictors = chain.deploy(
91-
instance_type="ml.g5.24xlarge",
93+
instance_type=INSTANCE_TYPE,
9294
initial_instance_count=1,
9395
accept_eula=True,
9496
endpoint_name=endpoint_name,

tests/unit/sagemaker/serve/builder/test_model_builder.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2967,7 +2967,8 @@ def test_deploy_existing_inference_component_calls_update_inference_component(
29672967
chain_builder = ModelBuilder(
29682968
modelbuilder_list=[builder1],
29692969
).build()
2970-
chain_builder.deploy()
2970+
inputs = {"endpoint_name": "endpoint-001"}
2971+
chain_builder.deploy(**inputs)
29712972
assert mock_update_inference_component.call_count == 1
29722973

29732974
def test_deploy_invalid_inputs(self):

0 commit comments

Comments
 (0)