Skip to content

Change job names in hyperparameter tuning integ tests #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

laurenyu
Copy link
Contributor

This is intended to help stabilize our tests when we do multiple PR runs by reducing the likelihood of hyperparameter tuning job name collisions.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #502 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          59       59           
  Lines        4621     4621           
=======================================
  Hits         4350     4350           
  Misses        271      271

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c27fd9...668bef0. Read the comment docs.

jesterhazy
jesterhazy previously approved these changes Nov 20, 2018
@jesterhazy
Copy link
Contributor

closing -- fix is duplicated in #530

@jesterhazy jesterhazy closed this Dec 7, 2018
@laurenyu laurenyu deleted the stabilize-tests branch December 10, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants