Skip to content

feat: triton v24.09 #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 31, 2024
Merged

feat: triton v24.09 #4908

merged 8 commits into from
Oct 31, 2024

Conversation

maaquib
Copy link
Collaborator

@maaquib maaquib commented Oct 22, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maaquib maaquib requested a review from a team as a code owner October 22, 2024 17:45
@maaquib maaquib requested a review from akrishna1995 October 22, 2024 17:45
@maaquib maaquib mentioned this pull request Oct 22, 2024
Merged
29 tasks
bhadrip
bhadrip reviewed Oct 22, 2024
View reviewed changes
Copy link

@bhadrip bhadrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we keep repeating the aws accounts for each version ? are we expecting the versions to not be available in a given region ?

@maaquib
Copy link
Collaborator Author

maaquib commented Oct 22, 2024

Why do we keep repeating the aws accounts for each version ? are we expecting the versions to not be available in a given region ?

Not really sure. This is the convention that I see across all config files. If you guys have a better way, I'm happy to adopt it

@bhadrip
Copy link

bhadrip commented Oct 22, 2024

@nargokul do you have any insights in this image formats ?

@bhadrip
Copy link

bhadrip commented Oct 22, 2024

approving it for now, we should refactor the image discovery feature. @nargokul can add more context on the future direction.

@nileshvd nileshvd merged commit f82e154 into aws:master Oct 31, 2024
13 of 14 checks passed
benieric added a commit that referenced this pull request Dec 4, 2024
@chrstfu @pintaoz-aws
@malav-shastri @Captainia @adtian2 @dependabot @liujiaorr @akrishna1995 @keshav-chandak @benieric @sagemaker-bot @ErnevSharma @tosterberg @nileshvd @maaquib
chore: Merge from main (#1600)
9a7b6de 
* prepare release v2.232.2

* update development version to v2.232.3.dev0

* fix: Use Miniforge to replace MambaForge (#4884)

* Use Miniforge to replace MambaForge

* Fix download url

* tests: Implement integration tests covering JumpStart PrivateHub workflows (#4883)

* tests: Implement integration tests covering JumpStart PrivateHub workflows

* linting

* formating

* Only delete the pytest session specific test

* change scope to session

* address nits

* Address test failures

* address typo

* address comments

* resolve flake8 errors

* implement throttle handling

* flake8

* flake8

* Adding more assertions

---------

Co-authored-by: malavhs <[email protected]>

* chore: add lmi image config in me-central-1 (#4887)

* changes for PT 2.4 currency upgrade (#4890)

Co-authored-by: Andrew Tian <[email protected]>

* chore(deps): bump pyspark from 3.3.1 to 3.3.2 in /requirements/extras (#4894)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update cloudpickle version to >=2.2.1 (#4891)

* update cloudpickle version to >=2.2.1 in pyproject.toml (#4899)

* Revert "update cloudpickle version to >=2.2.1 in pyproject.toml (#4899)" (#4902)

* release: huggingface tgi neuronx 0.0.25 image (#4893)

* release: huggingface tgi neuronx 0.0.25 image

* tests

* add tgi 2.3.1

* update default version

* update py version

* fix tests

* test

* Revert "fix tests"

This reverts commit 9374c75.

* Revert "Revert "fix tests""

This reverts commit 20d46d1.

* Revert "test"

This reverts commit 90f6e0b.

* fix: fixing typo in dependecy setup (#4905)

charset-normalizer is misplet in the
requirements.txt files

* Fix: Returning ModelPackage object on register of PipelineModel (#4878)

Co-authored-by: Keshav Chandak <[email protected]>

* fix: modified pull request template (#4906)

Added warning to spell check dependencies added
and ensure they exist in PyPi

* Fix: image_uris graviton image uri (#4909)

* change: update image_uri_configs  09-27-2024 07:18:01 PST

* change: update image_uri_configs  10-03-2024 07:17:59 PST

* change: update image_uri_configs  10-17-2024 07:17:55 PST

* change: update image_uri_configs  10-23-2024 11:26:03 PST

* change: adding eu-central-2 bucket info to JS constants (#4907)

* change: adding eu-central-2 bucket info to JS constants

* change: adding zrh image uris for dji neuronx

---------

Co-authored-by: shaernev <[email protected]>

* fix: Skip pytorch tests incompatible with latest version 2.4.0 (#4910)

* change: update image_uri_configs  10-29-2024 07:17:56 PST

* prepare release v2.232.3

* update development version to v2.232.4.dev0

* change: Updates for DJL 0.30.0 release (#4892)

Co-authored-by: pintaoz-aws <[email protected]>

* bumping smp version from 2.6.0 to 2.6.1 (#4913)

Co-authored-by: Andrew Tian <[email protected]>
Co-authored-by: nileshvd <[email protected]>

* feat: Marketplace model support in HubService (#4916)

* feat: Marketplace model support in HubService

* fix: removing field

* fix: Reverting name change for code coverage

* fix: Adding more code coverage

* fix: linting

* fix: Fixing coverage tests

* fix: Fixing integration tests

* fix: Minor fixes

* feat: triton v24.09 (#4908)

* fix: Fixing JumpStart Tests (#4917)

* fix: Fixing tests

* fix: fixing test name

* fix: dummy commit

* fix: reverting dummy commit

* fix: Removing flakey tests

---------

Co-authored-by: nileshvd <[email protected]>

* fix: merge

* fix: Commenting out marketplace test

* fix: Linting

---------

Co-authored-by: ci <ci>
Co-authored-by: pintaoz-aws <[email protected]>
Co-authored-by: Malav Shastri <[email protected]>
Co-authored-by: malavhs <[email protected]>
Co-authored-by: Haotian An <[email protected]>
Co-authored-by: adtian2 <[email protected]>
Co-authored-by: Andrew Tian <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: liujiaor <[email protected]>
Co-authored-by: ASHWIN KRISHNA <[email protected]>
Co-authored-by: Keshav Chandak <[email protected]>
Co-authored-by: Keshav Chandak <[email protected]>
Co-authored-by: Erick Benitez-Ramos <[email protected]>
Co-authored-by: sagemaker-bot <[email protected]>
Co-authored-by: Ernev Sharma <[email protected]>
Co-authored-by: shaernev <[email protected]>
Co-authored-by: Tyler Osterberg <[email protected]>
Co-authored-by: nileshvd <[email protected]>
Co-authored-by: Aaqib <[email protected]>
benieric added a commit that referenced this pull request Dec 5, 2024
@chrstfu @pintaoz-aws
@malav-shastri @Captainia @adtian2 @dependabot @liujiaorr @akrishna1995 @keshav-chandak @benieric @sagemaker-bot @ErnevSharma @tosterberg @nileshvd @maaquib
chore: Merge from main (#1600)
95e413e 
* prepare release v2.232.2

* update development version to v2.232.3.dev0

* fix: Use Miniforge to replace MambaForge (#4884)

* Use Miniforge to replace MambaForge

* Fix download url

* tests: Implement integration tests covering JumpStart PrivateHub workflows (#4883)

* tests: Implement integration tests covering JumpStart PrivateHub workflows

* linting

* formating

* Only delete the pytest session specific test

* change scope to session

* address nits

* Address test failures

* address typo

* address comments

* resolve flake8 errors

* implement throttle handling

* flake8

* flake8

* Adding more assertions

---------

Co-authored-by: malavhs <[email protected]>

* chore: add lmi image config in me-central-1 (#4887)

* changes for PT 2.4 currency upgrade (#4890)

Co-authored-by: Andrew Tian <[email protected]>

* chore(deps): bump pyspark from 3.3.1 to 3.3.2 in /requirements/extras (#4894)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update cloudpickle version to >=2.2.1 (#4891)

* update cloudpickle version to >=2.2.1 in pyproject.toml (#4899)

* Revert "update cloudpickle version to >=2.2.1 in pyproject.toml (#4899)" (#4902)

* release: huggingface tgi neuronx 0.0.25 image (#4893)

* release: huggingface tgi neuronx 0.0.25 image

* tests

* add tgi 2.3.1

* update default version

* update py version

* fix tests

* test

* Revert "fix tests"

This reverts commit 9374c75.

* Revert "Revert "fix tests""

This reverts commit 20d46d1.

* Revert "test"

This reverts commit 90f6e0b.

* fix: fixing typo in dependecy setup (#4905)

charset-normalizer is misplet in the
requirements.txt files

* Fix: Returning ModelPackage object on register of PipelineModel (#4878)

Co-authored-by: Keshav Chandak <[email protected]>

* fix: modified pull request template (#4906)

Added warning to spell check dependencies added
and ensure they exist in PyPi

* Fix: image_uris graviton image uri (#4909)

* change: update image_uri_configs  09-27-2024 07:18:01 PST

* change: update image_uri_configs  10-03-2024 07:17:59 PST

* change: update image_uri_configs  10-17-2024 07:17:55 PST

* change: update image_uri_configs  10-23-2024 11:26:03 PST

* change: adding eu-central-2 bucket info to JS constants (#4907)

* change: adding eu-central-2 bucket info to JS constants

* change: adding zrh image uris for dji neuronx

---------

Co-authored-by: shaernev <[email protected]>

* fix: Skip pytorch tests incompatible with latest version 2.4.0 (#4910)

* change: update image_uri_configs  10-29-2024 07:17:56 PST

* prepare release v2.232.3

* update development version to v2.232.4.dev0

* change: Updates for DJL 0.30.0 release (#4892)

Co-authored-by: pintaoz-aws <[email protected]>

* bumping smp version from 2.6.0 to 2.6.1 (#4913)

Co-authored-by: Andrew Tian <[email protected]>
Co-authored-by: nileshvd <[email protected]>

* feat: Marketplace model support in HubService (#4916)

* feat: Marketplace model support in HubService

* fix: removing field

* fix: Reverting name change for code coverage

* fix: Adding more code coverage

* fix: linting

* fix: Fixing coverage tests

* fix: Fixing integration tests

* fix: Minor fixes

* feat: triton v24.09 (#4908)

* fix: Fixing JumpStart Tests (#4917)

* fix: Fixing tests

* fix: fixing test name

* fix: dummy commit

* fix: reverting dummy commit

* fix: Removing flakey tests

---------

Co-authored-by: nileshvd <[email protected]>

* fix: merge

* fix: Commenting out marketplace test

* fix: Linting

---------

Co-authored-by: ci <ci>
Co-authored-by: pintaoz-aws <[email protected]>
Co-authored-by: Malav Shastri <[email protected]>
Co-authored-by: malavhs <[email protected]>
Co-authored-by: Haotian An <[email protected]>
Co-authored-by: adtian2 <[email protected]>
Co-authored-by: Andrew Tian <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: liujiaor <[email protected]>
Co-authored-by: ASHWIN KRISHNA <[email protected]>
Co-authored-by: Keshav Chandak <[email protected]>
Co-authored-by: Keshav Chandak <[email protected]>
Co-authored-by: Erick Benitez-Ramos <[email protected]>
Co-authored-by: sagemaker-bot <[email protected]>
Co-authored-by: Ernev Sharma <[email protected]>
Co-authored-by: shaernev <[email protected]>
Co-authored-by: Tyler Osterberg <[email protected]>
Co-authored-by: nileshvd <[email protected]>
Co-authored-by: Aaqib <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhadrip bhadrip bhadrip left review comments

@akrishna1995 akrishna1995 Awaiting requested review from akrishna1995 akrishna1995 is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maaquib @bhadrip @nileshvd