change: adding eu-central-2 bucket info to JS constants #4907

ErnevSharma · 2024-10-22T16:03:49Z

Issue #, if available:

Description of changes:

Adding JS bucket info. I verified through the Neo RIP service that their bucket is not available as of yet.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS-pratab · 2024-10-22T16:57:09Z

src/sagemaker/jumpstart/constants.py

            gated_content_bucket="jumpstart-private-cache-prod-eu-central-1",
            neo_content_bucket="sagemaker-sd-models-prod-eu-central-1",
        ),
+        JumpStartLaunchedRegionInfo(
+            region_name="eu-central-2",
+            content_bucket="jumpstart-cache-prod-eu-central-2",
+            gated_content_bucket="jumpstart-private-cache-prod-eu-central-2",
+        ),


Is the neo bucket not needed for this region?

Added to description: Adding JS bucket info. I verified through the Neo RIP service that their bucket is not available as of yet.

Then should you remove the neo bucket?

malav-shastri · 2024-10-22T17:23:00Z

src/sagemaker/image_uri_config/djl-neuronx.json

@@ -169,6 +176,7 @@
                "cn-north-1": "727897471807",
                "cn-northwest-1": "727897471807",
                "eu-central-1": "763104351884",
+                "eu-central-2": "380420809688",


are there any E2E tests covering this file? we should probably trigger those before merging.

* prepare release v2.232.2 * update development version to v2.232.3.dev0 * fix: Use Miniforge to replace MambaForge (#4884) * Use Miniforge to replace MambaForge * Fix download url * tests: Implement integration tests covering JumpStart PrivateHub workflows (#4883) * tests: Implement integration tests covering JumpStart PrivateHub workflows * linting * formating * Only delete the pytest session specific test * change scope to session * address nits * Address test failures * address typo * address comments * resolve flake8 errors * implement throttle handling * flake8 * flake8 * Adding more assertions --------- Co-authored-by: malavhs <[email protected]> * chore: add lmi image config in me-central-1 (#4887) * changes for PT 2.4 currency upgrade (#4890) Co-authored-by: Andrew Tian <[email protected]> * chore(deps): bump pyspark from 3.3.1 to 3.3.2 in /requirements/extras (#4894) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update cloudpickle version to >=2.2.1 (#4891) * update cloudpickle version to >=2.2.1 in pyproject.toml (#4899) * Revert "update cloudpickle version to >=2.2.1 in pyproject.toml (#4899)" (#4902) * release: huggingface tgi neuronx 0.0.25 image (#4893) * release: huggingface tgi neuronx 0.0.25 image * tests * add tgi 2.3.1 * update default version * update py version * fix tests * test * Revert "fix tests" This reverts commit 9374c75. * Revert "Revert "fix tests"" This reverts commit 20d46d1. * Revert "test" This reverts commit 90f6e0b. * fix: fixing typo in dependecy setup (#4905) charset-normalizer is misplet in the requirements.txt files * Fix: Returning ModelPackage object on register of PipelineModel (#4878) Co-authored-by: Keshav Chandak <[email protected]> * fix: modified pull request template (#4906) Added warning to spell check dependencies added and ensure they exist in PyPi * Fix: image_uris graviton image uri (#4909) * change: update image_uri_configs 09-27-2024 07:18:01 PST * change: update image_uri_configs 10-03-2024 07:17:59 PST * change: update image_uri_configs 10-17-2024 07:17:55 PST * change: update image_uri_configs 10-23-2024 11:26:03 PST * change: adding eu-central-2 bucket info to JS constants (#4907) * change: adding eu-central-2 bucket info to JS constants * change: adding zrh image uris for dji neuronx --------- Co-authored-by: shaernev <[email protected]> * fix: Skip pytorch tests incompatible with latest version 2.4.0 (#4910) * change: update image_uri_configs 10-29-2024 07:17:56 PST * prepare release v2.232.3 * update development version to v2.232.4.dev0 * change: Updates for DJL 0.30.0 release (#4892) Co-authored-by: pintaoz-aws <[email protected]> * bumping smp version from 2.6.0 to 2.6.1 (#4913) Co-authored-by: Andrew Tian <[email protected]> Co-authored-by: nileshvd <[email protected]> * feat: Marketplace model support in HubService (#4916) * feat: Marketplace model support in HubService * fix: removing field * fix: Reverting name change for code coverage * fix: Adding more code coverage * fix: linting * fix: Fixing coverage tests * fix: Fixing integration tests * fix: Minor fixes * feat: triton v24.09 (#4908) * fix: Fixing JumpStart Tests (#4917) * fix: Fixing tests * fix: fixing test name * fix: dummy commit * fix: reverting dummy commit * fix: Removing flakey tests --------- Co-authored-by: nileshvd <[email protected]> * fix: merge * fix: Commenting out marketplace test * fix: Linting --------- Co-authored-by: ci <ci> Co-authored-by: pintaoz-aws <[email protected]> Co-authored-by: Malav Shastri <[email protected]> Co-authored-by: malavhs <[email protected]> Co-authored-by: Haotian An <[email protected]> Co-authored-by: adtian2 <[email protected]> Co-authored-by: Andrew Tian <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: liujiaor <[email protected]> Co-authored-by: ASHWIN KRISHNA <[email protected]> Co-authored-by: Keshav Chandak <[email protected]> Co-authored-by: Keshav Chandak <[email protected]> Co-authored-by: Erick Benitez-Ramos <[email protected]> Co-authored-by: sagemaker-bot <[email protected]> Co-authored-by: Ernev Sharma <[email protected]> Co-authored-by: shaernev <[email protected]> Co-authored-by: Tyler Osterberg <[email protected]> Co-authored-by: nileshvd <[email protected]> Co-authored-by: Aaqib <[email protected]>

change: adding eu-central-2 bucket info to JS constants

5d26c2b

ErnevSharma requested a review from a team as a code owner October 22, 2024 16:03

ErnevSharma requested a review from sage-maker October 22, 2024 16:03

ErnevSharma temporarily deployed to auto-approve October 22, 2024 16:04 — with GitHub Actions Inactive

malav-shastri approved these changes Oct 22, 2024

View reviewed changes

tlian25 approved these changes Oct 22, 2024

View reviewed changes

AWS-pratab reviewed Oct 22, 2024

View reviewed changes

change: adding zrh image uris for dji neuronx

1fb761c

ErnevSharma temporarily deployed to auto-approve October 22, 2024 17:15 — with GitHub Actions Inactive

malav-shastri reviewed Oct 22, 2024

View reviewed changes

malav-shastri approved these changes Oct 22, 2024

View reviewed changes

Merge branch 'master' into change-zrh-js-buckets

86693e2

ErnevSharma temporarily deployed to auto-approve October 22, 2024 18:16 — with GitHub Actions Inactive

Merge branch 'master' into change-zrh-js-buckets

5bff245

ErnevSharma temporarily deployed to auto-approve October 24, 2024 16:45 — with GitHub Actions Inactive

nargokul approved these changes Oct 24, 2024

View reviewed changes

nargokul merged commit 5a87413 into aws:master Oct 24, 2024
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change: adding eu-central-2 bucket info to JS constants #4907

change: adding eu-central-2 bucket info to JS constants #4907

ErnevSharma commented Oct 22, 2024 •

edited

Loading

AWS-pratab Oct 22, 2024

ErnevSharma Oct 22, 2024

JGuinegagne Oct 22, 2024

malav-shastri Oct 22, 2024

change: adding eu-central-2 bucket info to JS constants #4907

change: adding eu-central-2 bucket info to JS constants #4907

Conversation

ErnevSharma commented Oct 22, 2024 • edited Loading

Merge Checklist

General

Tests

AWS-pratab Oct 22, 2024

Choose a reason for hiding this comment

ErnevSharma Oct 22, 2024

Choose a reason for hiding this comment

JGuinegagne Oct 22, 2024

Choose a reason for hiding this comment

malav-shastri Oct 22, 2024

Choose a reason for hiding this comment

ErnevSharma commented Oct 22, 2024 •

edited

Loading