Support multi-part uploads #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS master
owen-t
previously approved these changes
Jan 18, 2018
| @@ -20,3 +20,4 @@ examples/tensorflow/distributed_mnist/data | |||
| doc/_build | |||
| **/.DS_Store | |||
| venv/ | |||
| *~ | |||
There was a problem hiding this comment.
Can this make it into the commit message as well.
There was a problem hiding this comment.
Yeah I accidentally added an emacs file on our fork. You mean you want a new commit in this PR with a message about that change?
There was a problem hiding this comment.
It's a good addition, happy for it to be part of this PR. If we leave it in this PR, can the commit message just reference the addition. Something like
"Upload files to S3 using multipart uploads.
Emacs temporary files covered in .gitignore"
There was a problem hiding this comment.
Yeah I'm happy to add it. Any idea if amending my commit message and force pushing to our fork will do it?
|
Thanks for your submission! |
Ignore Emacs backup files
owen-t
approved these changes
Jan 19, 2018
ragavvenkatesan
pushed a commit
that referenced
this pull request
Jan 30, 2018
* add sagemaker cli (#32) * add sagemaker cli * remove unnecessary close * address PR comments * tidy up imports * fix imports, flake8 errors * improve help message for bucket-name * remove default role name * fix log-level and py3 tests, add copyright * update cli example scripts * Add documentation about BYO Models (#47) * Add test for BYO estimator using Factorization Machines algorithm as an example. (#50) * Support multi-part uploads (#45) * Update TensorFlow examples following API change (#44) * Add data_type to hyperparameters (#54) When we describe a training job the data type of the hyper parameters is lost because we use a dict[str, str]. This adds a new field to Hyperparameter so that we can convert the datatypes at runtime. instead of validating with isinstance(), we cast the hp value to the type it is meant to be. This enforces a "strongly typed" value. When we deserialize from the API string responses it becomes easier to deal with too.
Closed
laurenyu
pushed a commit
to laurenyu/sagemaker-python-sdk
that referenced
this pull request
May 31, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large datasets, the current
Session.upload_datamethod fails. This PR switches the call toObject.upload_filewhich can do multi-part uploads. Also updated the unit tests.