fix: tolerate vulnerable old model for integ test and temporarily skip test_list_jumpstart_models_script_filter #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanasudhan
approved these changes
Feb 26, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
evakravi
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4453 +/- ##
==========================================
+ Coverage 86.94% 87.15% +0.21%
==========================================
Files 1203 387 -816
Lines 107211 35788 -71423
==========================================
- Hits 93211 31191 -62020
+ Misses 14000 4597 -9403 ☔ View full report in Codecov by Sentry. |
bencrabtree
pushed a commit
to bencrabtree/sagemaker-python-sdk
that referenced
this pull request
Feb 28, 2024
…p test_list_jumpstart_models_script_filter (aws#4453) * fix: tolerate vulnerable old model for integ test * chore: temporarily skip test_list_jumpstart_models_script_filter * chore: increase skip date to may
malav-shastri
pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
…p test_list_jumpstart_models_script_filter (aws#4453) * fix: tolerate vulnerable old model for integ test * chore: temporarily skip test_list_jumpstart_models_script_filter * chore: increase skip date to may
jiapinw
pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
…p test_list_jumpstart_models_script_filter (aws#4453) * fix: tolerate vulnerable old model for integ test * chore: temporarily skip test_list_jumpstart_models_script_filter * chore: increase skip date to may
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
meta-textgeneration-llama-2-7bversion2.*contains a vulnerability. For the purposes of passing the integ test (in case customers choose to use the vulnerable old model version), we tolerate the vulnerability.test_list_jumpstart_models_script_filteris flaky and will be temporarily skipped until JumpStart can figure out the root cause and write a fix.Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.