Skip to content

Commit 14f3441

Browse files
evakraviroot
authored and
root
committed
fix: tolerate vulnerable old model for integ test and temporarily skip test_list_jumpstart_models_script_filter (aws#4453)
* fix: tolerate vulnerable old model for integ test * chore: temporarily skip test_list_jumpstart_models_script_filter * chore: increase skip date to may
1 parent 08886bd commit 14f3441

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

tests/integ/sagemaker/jumpstart/estimator/test_jumpstart_estimator.py

+1
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ def test_gated_model_training_v1(setup):
108108
tags=[{"Key": JUMPSTART_TAG, "Value": os.environ[ENV_VAR_JUMPSTART_SDK_TEST_SUITE_ID]}],
109109
environment={"accept_eula": "true"},
110110
max_run=259200, # avoid exceeding resource limits
111+
tolerate_vulnerable_model=True,
111112
)
112113

113114
# uses ml.g5.12xlarge instance

tests/unit/sagemaker/jumpstart/test_notebook_utils.py

+5
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
from unittest import TestCase
55
from unittest.mock import Mock, patch
6+
import datetime
67

78
import pytest
89
from sagemaker.jumpstart.constants import (
@@ -207,6 +208,10 @@ def test_list_jumpstart_models_simple_case(
207208
patched_get_manifest.assert_called()
208209
patched_get_model_specs.assert_not_called()
209210

211+
@pytest.mark.skipif(
212+
datetime.datetime.now() < datetime.datetime(year=2024, month=5, day=1),
213+
reason="Contact JumpStart team to fix flaky test.",
214+
)
210215
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
211216
@patch("sagemaker.jumpstart.notebook_utils.DEFAULT_JUMPSTART_SAGEMAKER_SESSION.read_s3_file")
212217
def test_list_jumpstart_models_script_filter(

0 commit comments

Comments
 (0)