feature: Add XGBoost framework 1.7-1 version #3706

NikhilRaverkar · 2023-03-08T21:41:58Z

Issue #, if available:

Description of changes:
This PR adds a new version of xgboost 1.7-1.
Testing done:
python3 -m tox -e py37 tests/unit

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-03-08T22:29:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4cfebe4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T22:32:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4cfebe4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T22:35:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4cfebe4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-03-08T22:35:36Z

Codecov Report

Merging #3706 (7ec1160) into master (9f74fbc) will decrease coverage by 0.77%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
- Coverage   89.82%   89.05%   -0.77%     
==========================================
  Files         980      231     -749     
  Lines       92212    22827   -69385     
==========================================
- Hits        82828    20329   -62499     
+ Misses       9384     2498    -6886

Impacted Files	Coverage Δ
src/sagemaker/jumpstart/artifacts.py	`92.30% <85.71%> (ø)`
src/sagemaker/metric_definitions.py	`90.90% <90.90%> (ø)`
src/sagemaker/jumpstart/types.py	`95.03% <100.00%> (ø)`

... and 1208 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-03-08T22:39:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4cfebe4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-09T00:43:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4cfebe4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-09T16:16:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2a4beb6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-09T16:21:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2a4beb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-09T16:25:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2a4beb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-09T16:30:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2a4beb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-09T18:35:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2a4beb6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T15:40:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5aebd2d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T16:11:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5aebd2d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T16:57:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 680d76d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T17:08:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 680d76d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T17:11:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 680d76d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T17:29:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 680d76d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T17:36:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 680d76d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T17:56:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7ec1160
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T18:38:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7ec1160
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T18:41:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7ec1160
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T18:44:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7ec1160
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-10T19:27:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7ec1160
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

secastillo · 2023-03-10T19:29:02Z

src/sagemaker/image_uri_config/xgboost.json

+                    "ap-south-1": "720646828776",
+                    "ap-southeast-1": "121021644041",
+                    "ap-southeast-2": "783357654285",
+                    "ap-southeast-3": "951798379941",


I think our recent deployments actually added 1.7-1 to the new regions as well. Could you double check (i.e. look into the ECR accounts of the new regions for this tagged image) and then add them here as well? Thanks!

Amending my comment slightly, since I noticed we're not in the staging repo. Could you either make a PR to the staging repo for the change I mentioned above, or a backlog item for us to do so ? Thanks!

Good point! I'll create a backlog for launching all versions of XGB and SKLearn in those 4 regions.

mufaddal-rohawala

/bot run slow-tests

sagemaker-bot · 2023-03-11T00:20:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7ec1160
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Nikhil Raverkar <[email protected]>

Nikhil Raverkar and others added 2 commits March 6, 2023 12:47

xgboost-1.7 launch config

948a804

Merge branch 'aws:master' into xgb-1.7-1_launch

4cfebe4

Merge branch 'master' into xgb-1.7-1_launch

2a4beb6

Merge branch 'master' into xgb-1.7-1_launch

5aebd2d

NikhilRaverkar added 2 commits March 10, 2023 21:50

Update test_xgboost.py

49e6692

Update test_xgboost.py

680d76d

NikhilRaverkar requested review from mufaddal-rohawala and navinsoni March 10, 2023 17:50

Merge branch 'master' into xgb-1.7-1_launch

7ec1160

NikhilRaverkar marked this pull request as ready for review March 10, 2023 17:50

NikhilRaverkar requested a review from a team as a code owner March 10, 2023 17:50

secastillo suggested changes Mar 10, 2023

View reviewed changes

secastillo approved these changes Mar 10, 2023

View reviewed changes

mufaddal-rohawala self-assigned this Mar 10, 2023

mufaddal-rohawala approved these changes Mar 10, 2023

View reviewed changes

mufaddal-rohawala reviewed Mar 10, 2023

View reviewed changes

NikhilRaverkar mentioned this pull request Mar 13, 2023

Feature: add SKLearn framework version 1.2-1 #3713

Merged

9 tasks

NikhilRaverkar removed the request for review from navinsoni March 13, 2023 15:09

knikure merged commit adee8b2 into aws:master Mar 13, 2023

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

feature: Add XGBoost framework 1.7-1 version (aws#3706)

5a877f8

Co-authored-by: Nikhil Raverkar <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Add XGBoost framework 1.7-1 version #3706

feature: Add XGBoost framework 1.7-1 version #3706

NikhilRaverkar commented Mar 8, 2023

sagemaker-bot commented Mar 8, 2023

sagemaker-bot commented Mar 8, 2023

sagemaker-bot commented Mar 8, 2023

codecov-commenter commented Mar 8, 2023 •

edited

Loading

sagemaker-bot commented Mar 8, 2023

sagemaker-bot commented Mar 9, 2023

sagemaker-bot commented Mar 9, 2023

sagemaker-bot commented Mar 9, 2023

sagemaker-bot commented Mar 9, 2023

sagemaker-bot commented Mar 9, 2023

sagemaker-bot commented Mar 9, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

sagemaker-bot commented Mar 10, 2023

secastillo Mar 10, 2023 •

edited

Loading

secastillo Mar 10, 2023

NikhilRaverkar Mar 10, 2023

mufaddal-rohawala left a comment

sagemaker-bot commented Mar 11, 2023

feature: Add XGBoost framework 1.7-1 version #3706

feature: Add XGBoost framework 1.7-1 version #3706

Conversation

NikhilRaverkar commented Mar 8, 2023

Merge Checklist

General

Tests

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

codecov-commenter commented Mar 8, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

secastillo Mar 10, 2023 • edited Loading

Choose a reason for hiding this comment

secastillo Mar 10, 2023

Choose a reason for hiding this comment

NikhilRaverkar Mar 10, 2023

Choose a reason for hiding this comment

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Mar 11, 2023

AWS CodeBuild CI Report

codecov-commenter commented Mar 8, 2023 •

edited

Loading

secastillo Mar 10, 2023 •

edited

Loading