fix: tag permission issue - remove describe before create #3662

mufaddal-rohawala · 2023-02-16T05:58:53Z

This reverts commit 5bc3ccf.Issue #, if available:

Description of changes:
The changes help fix the resource based tag related routines to unblock customers to use resource tags.
Issue 1: Tag permission issue due to describe before create
Fix: Describe before create routines are now switched to create and check for resource existence, to unblock tag based access.
Issue 2: Tag propagation delay
Fix: On resource create and wait for resource creation - we will now wait for tag propagation.

Testing done:
Tested all units and integs as part of the PR checks.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-02-16T06:03:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1c9480e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-16T06:51:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1c9480e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-16T06:59:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1c9480e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-16T08:31:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1c9480e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-16T08:51:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1c9480e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aws#3285)" This reverts commit 5bc3ccf.

sagemaker-bot · 2023-02-17T01:07:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fe231bf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T02:18:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b4afaed
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T02:21:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b4afaed
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T02:25:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b4afaed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T03:14:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9e0d5b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T03:24:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9e0d5b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T03:25:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9e0d5b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run slow-tests

sagemaker-bot · 2023-02-17T03:37:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9e0d5b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T03:40:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9e0d5b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T04:20:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9e0d5b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T05:06:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8bda04a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T05:16:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8bda04a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T06:27:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f7b8dd1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T06:33:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f7b8dd1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T06:38:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f7b8dd1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T07:45:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3d00085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T08:15:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T08:25:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T08:34:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T08:45:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run slow-tests

sagemaker-bot · 2023-02-17T19:32:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T19:41:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T19:47:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T20:34:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T20:42:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T20:51:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T21:10:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3d00085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T22:41:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3d00085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T23:24:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3d00085
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-17T23:36:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3d00085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

qidewenwhen · 2023-02-17T22:49:07Z

src/sagemaker/experiments/experiment.py

+            error_code = ce.response["Error"]["Code"]
+            error_message = ce.response["Error"]["Message"]
+            if not (error_code == "ValidationException" and "already exists" in error_message):
+                raise ce


Nit: these lines of code keeps repeating. May be good to extract them to a helper function

ack, a definite improvement

+1 to that. Also I don't like the idea of logic depending on the parsed error message. As error messages are prone to change and will break the logic

src/sagemaker/workflow/pipeline.py

src/sagemaker/experiments/experiment.py

src/sagemaker/session.py

leoroy

The experiment-related changes look good to me

mufaddal-rohawala

/bot run slow-tests

sagemaker-bot · 2023-02-21T05:40:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3d00085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* fix: tag permission issue - remove describe before create * Revert "fix: Add retry in session.py to check if training is finished (aws#3285)" This reverts commit 5bc3ccf. * fix: job wait logic to wait for tag propagation * fix: add tag fixes for pipelines and experiments

mufaddal-rohawala added 3 commits February 16, 2023 17:02

fix: tag permission issue - remove describe before create

e7ed90d

Revert "fix: Add retry in session.py to check if training is finished (…

c98b231

…aws#3285)" This reverts commit 5bc3ccf.

fix: job wait logic to wait for tag propagation

607f85a

mufaddal-rohawala force-pushed the tag-fixes branch from 1c9480e to fe231bf Compare February 17, 2023 01:03

mufaddal-rohawala force-pushed the tag-fixes branch from b4afaed to 9e0d5b5 Compare February 17, 2023 02:30

mufaddal-rohawala marked this pull request as ready for review February 17, 2023 02:49

mufaddal-rohawala requested a review from a team as a code owner February 17, 2023 02:49

mufaddal-rohawala requested review from vikas0203 and removed request for a team February 17, 2023 02:49

mufaddal-rohawala commented Feb 17, 2023

View reviewed changes

mufaddal-rohawala requested review from leoroy and qidewenwhen February 17, 2023 04:05

mufaddal-rohawala force-pushed the tag-fixes branch from 9e0d5b5 to 8bda04a Compare February 17, 2023 04:28

fix: add tag fixes for pipelines and experiments

3d00085

mufaddal-rohawala force-pushed the tag-fixes branch from f7b8dd1 to 3d00085 Compare February 17, 2023 07:38

mufaddal-rohawala commented Feb 17, 2023

View reviewed changes

qidewenwhen approved these changes Feb 17, 2023

View reviewed changes

vikas0203 approved these changes Feb 17, 2023

View reviewed changes

mufaddal-rohawala requested a review from ZhangHan February 18, 2023 00:10

leoroy approved these changes Feb 18, 2023

View reviewed changes

mufaddal-rohawala commented Feb 21, 2023

View reviewed changes

claytonparnell merged commit dffc562 into aws:master Feb 21, 2023

fix: tag permission issue - remove describe before create #3662

fix: tag permission issue - remove describe before create #3662

Conversation

mufaddal-rohawala commented Feb 16, 2023 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2023

mufaddal-rohawala commented Feb 16, 2023 •

edited

Loading

arkaprava08 Feb 20, 2023 •

edited

Loading