Skip to content

fix: Add retry in session.py to check if training is finished #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2022
Merged

fix: Add retry in session.py to check if training is finished #3285

merged 2 commits into from
Aug 26, 2022

Conversation

navinsoni
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4f14e19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022 •
edited
Loading

Codecov Report

Merging #3285 (4ca9c27) into master (49c6648) will decrease coverage by 0.78%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
- Coverage   89.93%   89.15%   -0.79%     
==========================================
  Files         651      204     -447     
  Lines       57420    18911   -38509     
==========================================
- Hits        51643    16860   -34783     
+ Misses       5777     2051    -3726
Impacted Files Coverage Δ
src/sagemaker/session.py 71.66% <68.75%> (ø)
...thon3.8/site-packages/sagemaker/jumpstart/utils.py
...y39/lib/python3.9/site-packages/sagemaker/model.py
...7/site-packages/sagemaker/drift_check_baselines.py
...hon3.9/site-packages/sagemaker/mxnet/processing.py
.../sagemaker/cli/compatibility/v2/modifiers/serde.py
...site-packages/sagemaker/workflow/condition_step.py
.../py37/lib/python3.7/site-packages/sagemaker/job.py
...n3.9/site-packages/sagemaker/wrangler/ingestion.py
...3.9/site-packages/sagemaker/workflow/model_step.py
... and 846 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4f14e19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4f14e19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4f14e19
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 4f14e19
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4ca9c27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4ca9c27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4ca9c27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4ca9c27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 4ca9c27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala mufaddal-rohawala merged commit 5bc3ccf into aws:master Aug 26, 2022
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 4ca9c27
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4ca9c27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4ca9c27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4ca9c27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4ca9c27
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala added a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Feb 16, 2023
@mufaddal-rohawala
Revert "fix: Add retry in session.py to check if training is finished (…
3d212ac 
…aws#3285)"

This reverts commit 5bc3ccf.
@mufaddal-rohawala mufaddal-rohawala mentioned this pull request Feb 16, 2023
Merged
9 tasks
mufaddal-rohawala added a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Feb 17, 2023
@mufaddal-rohawala
Revert "fix: Add retry in session.py to check if training is finished (…
c98b231 
…aws#3285)"

This reverts commit 5bc3ccf.
claytonparnell pushed a commit that referenced this pull request Feb 21, 2023
@mufaddal-rohawala
fix: tag permission issue - remove describe before create (#3662)
dffc562 
* fix: tag permission issue - remove describe before create

* Revert "fix: Add retry in session.py to check if training is finished (#3285)"

This reverts commit 5bc3ccf.

* fix: job wait logic to wait for tag propagation

* fix: add tag fixes for pipelines and experiments
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@navinsoni @BasilBeirouti @JoseJuan98
fix: Add retry in session.py to check if training is finished (aws#3285)
01124c5 
Co-authored-by: Basil Beirouti <[email protected]>
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@mufaddal-rohawala @JoseJuan98
fix: tag permission issue - remove describe before create (aws#3662)
b73eb1f 
* fix: tag permission issue - remove describe before create

* Revert "fix: Add retry in session.py to check if training is finished (aws#3285)"

This reverts commit 5bc3ccf.

* fix: job wait logic to wait for tag propagation

* fix: add tag fixes for pipelines and experiments
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@mufaddal-rohawala
fix: tag permission issue - remove describe before create (aws#3662)
67e5e1b 
* fix: tag permission issue - remove describe before create

* Revert "fix: Add retry in session.py to check if training is finished (aws#3285)"

This reverts commit 5bc3ccf.

* fix: job wait logic to wait for tag propagation

* fix: add tag fixes for pipelines and experiments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navinsoni @sagemaker-bot @codecov-commenter @mufaddal-rohawala @BasilBeirouti