feature: right_size() for inference recommender #3570

gwang111 · 2023-01-05T21:15:21Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

gwang111 · 2023-01-05T21:16:33Z

Approved by @trajanikant. Moving merged changes from staging repo to public

trajanikant

/bot run all

sagemaker-bot · 2023-01-06T00:11:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f965fcf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T00:45:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f965fcf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-01-06T00:45:51Z

Codecov Report

Merging #3570 (d5c3b09) into master (37c0d3a) will decrease coverage by 0.75%.
The diff coverage is 93.85%.

@@            Coverage Diff             @@
##           master    #3570      +/-   ##
==========================================
- Coverage   89.55%   88.80%   -0.76%     
==========================================
  Files         960      227     -733     
  Lines       88796    22136   -66660     
==========================================
- Hits        79523    19658   -59865     
+ Misses       9273     2478    -6795

Impacted Files	Coverage Δ
...ference_recommender/inference_recommender_mixin.py	`87.50% <87.50%> (ø)`
src/sagemaker/model.py	`92.97% <87.50%> (ø)`
src/sagemaker/session.py	`74.02% <100.00%> (ø)`
.../cli/compatibility/v2/modifiers/training_params.py
...python3.8/site-packages/sagemaker/lambda_helper.py
...python3.9/site-packages/sagemaker/lambda_helper.py
....8/site-packages/sagemaker/jumpstart/validators.py
....7/site-packages/sagemaker/feature_store/inputs.py
...lib/python3.8/site-packages/sagemaker/predictor.py
...b/python3.9/site-packages/sagemaker/local/image.py
... and 1179 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-01-06T00:48:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f965fcf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T01:09:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f965fcf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T01:34:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f965fcf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run notebook-tests, slow-tests

sagemaker-bot · 2023-01-06T02:43:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f965fcf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T03:09:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f965fcf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests

sagemaker-bot · 2023-01-06T17:53:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f965fcf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* feature: Add create inf rec api to session * save * fix error handling in submit. update docstring * add in job_name param Co-authored-by: Gary Wang <[email protected]>

* feature: Add create inf rec api to session * save * fix error handling in submit. update docstring * add in job_name param * fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * feature: add describe inf rec api to session * feature: add describe inf rec api to session * feature: add describe inf rec api to session * add verbose logging in wait_for_inference_recommendations_job * improve unit tests * switch to cloudwatch logs * add unit tests * fix unit test * make default logging level to Verbose * address comments in PR * address some comments * fix typo missing s * add initial print because it took a while for cw logstream to appear * print and conditional optimizations and update tests * optimize log print * fix polling for logs empty events * cover empty event case * add spacing Co-authored-by: Gary Wang <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Raymond Liu <[email protected]>

* feature: right_sizing() for inf rec * update imports and documentation * updated mixin * one more unit test * leverage more fixtures * one more unit test * check args changes and tests * naming change * fix doc strings, infer job_type * add sphynx doc change * integration testing * add integration tests for default case with sklearn * should delete model package only at the very end of tests * update integ test for defalut job * add integ test for advanced job * cleanup integ tests * update role * add quiet integ test * remove trailing spaces * fix doc string * fix logging format * reformatting * update sphinx doc * refactoring our error handling * refactor error handling * remove unused params from doc string * refactor error handling and integ tests * fix integ tests * switch role * refactor timeout and cleanup * fix flake8 failure * refactor check logic * remove unnecessary logging * make jobName truly unique Co-authored-by: Gary Wang <[email protected]> Co-authored-by: Raymond Liu <[email protected]>

trajanikant

/bot run all

sagemaker-bot · 2023-01-06T21:41:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d5c3b09
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T22:16:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d5c3b09
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T22:19:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d5c3b09
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T22:30:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d5c3b09
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T22:39:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d5c3b09
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests, unit-tests

sagemaker-bot · 2023-01-07T00:38:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d5c3b09
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-07T02:52:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d5c3b09
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests

sagemaker-bot · 2023-01-09T20:39:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d5c3b09
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests

sagemaker-bot · 2023-01-09T23:45:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d5c3b09
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests

sagemaker-bot · 2023-01-10T01:23:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d5c3b09
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Gary Wang <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Raymond Liu <[email protected]>

gwang111 requested a review from a team as a code owner January 5, 2023 21:15

gwang111 requested review from knikure and removed request for a team January 5, 2023 21:15

gwang111 force-pushed the right_size_feature branch from 2ed528c to f965fcf Compare January 5, 2023 23:31

trajanikant self-assigned this Jan 6, 2023

trajanikant reviewed Jan 6, 2023

View reviewed changes

gwang111 and others added 3 commits January 6, 2023 11:45

feature: Add create inf rec api to session (aws#761)

414a77c

* feature: Add create inf rec api to session * save * fix error handling in submit. update docstring * add in job_name param Co-authored-by: Gary Wang <[email protected]>

gwang111 force-pushed the right_size_feature branch from f965fcf to d5c3b09 Compare January 6, 2023 19:45

trajanikant reviewed Jan 6, 2023

View reviewed changes

trajanikant reviewed Jan 9, 2023

View reviewed changes

trajanikant approved these changes Jan 9, 2023

View reviewed changes

trajanikant reviewed Jan 10, 2023

View reviewed changes

trajanikant merged commit 6f8feec into aws:master Jan 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: right_size() for inference recommender #3570

feature: right_size() for inference recommender #3570

gwang111 commented Jan 5, 2023 •

edited

Loading

gwang111 commented Jan 5, 2023

trajanikant left a comment

sagemaker-bot commented Jan 6, 2023

sagemaker-bot commented Jan 6, 2023

codecov-commenter commented Jan 6, 2023 •

edited

Loading

sagemaker-bot commented Jan 6, 2023

sagemaker-bot commented Jan 6, 2023

sagemaker-bot commented Jan 6, 2023

trajanikant left a comment

sagemaker-bot commented Jan 6, 2023

sagemaker-bot commented Jan 6, 2023

trajanikant left a comment

sagemaker-bot commented Jan 6, 2023

trajanikant left a comment

sagemaker-bot commented Jan 6, 2023

sagemaker-bot commented Jan 6, 2023

sagemaker-bot commented Jan 6, 2023

sagemaker-bot commented Jan 6, 2023

sagemaker-bot commented Jan 6, 2023

trajanikant left a comment

sagemaker-bot commented Jan 7, 2023

sagemaker-bot commented Jan 7, 2023

trajanikant left a comment

sagemaker-bot commented Jan 9, 2023

trajanikant left a comment

sagemaker-bot commented Jan 9, 2023

trajanikant left a comment

sagemaker-bot commented Jan 10, 2023

feature: right_size() for inference recommender #3570

feature: right_size() for inference recommender #3570

Conversation

gwang111 commented Jan 5, 2023 • edited Loading

Merge Checklist

General

Tests

gwang111 commented Jan 5, 2023

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

codecov-commenter commented Jan 6, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jan 7, 2023

AWS CodeBuild CI Report

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 9, 2023

AWS CodeBuild CI Report

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 9, 2023

AWS CodeBuild CI Report

trajanikant left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

gwang111 commented Jan 5, 2023 •

edited

Loading

codecov-commenter commented Jan 6, 2023 •

edited

Loading