Skip to content

doc: add clarification around framework version constants #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

laurenyu
Copy link
Contributor

Issue #, if available:
#754

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@icywang86rui
Copy link
Contributor

do we need a changelog entry for this?

Copy link
Contributor

@icywang86rui icywang86rui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu laurenyu merged commit 34d2849 into aws:master Apr 23, 2019
@laurenyu laurenyu deleted the fw-version-doc branch April 23, 2019 19:02
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 5, 2023
* feature: Add create inf rec api to session

* save

* fix error handling in submit. update docstring

* add in job_name param

Co-authored-by: Gary Wang <[email protected]>
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 5, 2023
* feature: Add create inf rec api to session

* save

* fix error handling in submit. update docstring

* add in job_name param

Co-authored-by: Gary Wang <[email protected]>
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 6, 2023
* feature: Add create inf rec api to session

* save

* fix error handling in submit. update docstring

* add in job_name param

Co-authored-by: Gary Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants