Skip to content

feature: do not expand estimator role when it is pipeline parameter #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

feature: do not expand estimator role when it is pipeline parameter #3416

merged 1 commit into from
Oct 21, 2022

Conversation

ivannotes
Copy link
Contributor

Issue #, if available:

#3414

Description of changes:

Currently when dump the pipeline definition if estimator role is assigned with a pipeline parameter, the SDK will raise error as pipeline parameter expected as a valid input. This change is to support pass pipeline parameter to the role and don't expand it when load the job config.

Testing done:

tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • [] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

navaj0
navaj0 reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@navaj0 navaj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also check the Processor and Transformer implementation as well?

@claytonparnell
feature: do not expand estimator role when it is pipeline parameter
03956f1 
Currently when dump the pipeline definition if estimator role is
assigned with a pipeline parameter, the SDK will raise error as pipeline
parameter expected as a valid input. This change is to support pass
pipeline parameter to the role and don't expand it when load the job
config.
claytonparnell
claytonparnell reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@claytonparnell claytonparnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 03956f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #3416 (03956f1) into master (1fa2377) will decrease coverage by 0.22%.
The diff coverage is 82.79%.

@@            Coverage Diff             @@
##           master    #3416      +/-   ##
==========================================
- Coverage   89.17%   88.95%   -0.23%     
==========================================
  Files         204      205       +1     
  Lines       18979    19070      +91     
==========================================
+ Hits        16924    16963      +39     
- Misses       2055     2107      +52
Impacted Files Coverage Δ
src/sagemaker/sklearn/model.py 92.98% <ø> (-1.76%) ⬇️
...sagemaker/workflow/monitor_batch_transform_step.py 0.00% <0.00%> (ø)
src/sagemaker/workflow/utilities.py 94.31% <ø> (ø)
src/sagemaker/xgboost/model.py 96.36% <ø> (-1.82%) ⬇️
src/sagemaker/session.py 71.41% <28.57%> (-0.25%) ⬇️
src/sagemaker/training_compiler/config.py 80.43% <60.00%> (-2.90%) ⬇️
src/sagemaker/sklearn/estimator.py 93.93% <63.63%> (-6.07%) ⬇️
src/sagemaker/estimator.py 89.43% <71.42%> (-0.08%) ⬇️
src/sagemaker/amazon/amazon_estimator.py 87.82% <81.25%> (-0.62%) ⬇️
src/sagemaker/amazon/lda.py 98.03% <92.30%> (+0.16%) ⬆️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 03956f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 03956f1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 03956f1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 03956f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell
claytonparnell reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@claytonparnell claytonparnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests, notebook-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 03956f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 03956f1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell
claytonparnell reviewed Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@claytonparnell claytonparnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 03956f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@claytonparnell claytonparnell merged commit 1a39422 into aws:master Oct 21, 2022
mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
@ivannotes @mufiAmazon
feature: do not expand estimator role when it is pipeline parameter (a…
e4327d0 
…ws#3416)

Currently when dump the pipeline definition if estimator role is
assigned with a pipeline parameter, the SDK will raise error as pipeline
parameter expected as a valid input. This change is to support pass
pipeline parameter to the role and don't expand it when load the job
config.

Co-authored-by: Yi Li <[email protected]>
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@ivannotes @JoseJuan98
feature: do not expand estimator role when it is pipeline parameter (a…
fa472ad 
…ws#3416)

Currently when dump the pipeline definition if estimator role is
assigned with a pipeline parameter, the SDK will raise error as pipeline
parameter expected as a valid input. This change is to support pass
pipeline parameter to the role and don't expand it when load the job
config.

Co-authored-by: Yi Li <[email protected]>
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@ivannotes
feature: do not expand estimator role when it is pipeline parameter (a…
caa868c 
…ws#3416)

Currently when dump the pipeline definition if estimator role is
assigned with a pipeline parameter, the SDK will raise error as pipeline
parameter expected as a valid input. This change is to support pass
pipeline parameter to the role and don't expand it when load the job
config.

Co-authored-by: Yi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navaj0 navaj0 navaj0 approved these changes

@claytonparnell claytonparnell claytonparnell approved these changes

@nmadan nmadan nmadan approved these changes

@qidewenwhen qidewenwhen qidewenwhen approved these changes

@jerrypeng7773 jerrypeng7773 jerrypeng7773 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ivannotes @sagemaker-bot @codecov-commenter @nmadan @navaj0 @qidewenwhen @claytonparnell @jerrypeng7773