Skip to content

Accept pipeline parameters as estimator/processor roles #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
navaj0 opened this issue Oct 13, 2022 · 3 comments
Closed

Accept pipeline parameters as estimator/processor roles #3414

navaj0 opened this issue Oct 13, 2022 · 3 comments
Labels
component: pipelines Relates to the SageMaker Pipeline Platform type: feature request

Comments

@navaj0
Copy link
Contributor

navaj0 commented Oct 13, 2022

Describe the feature you'd like

Accept pipeline parameters as estimator/processor roles

According to the SDK API doc, the role can’t be assigned to a pipeline parameter.

  • image_uri (str or PipelineVariable) – The container image to use for training.
  • role (str) – An AWS IAM role (either name or full ARN). The Amazon SageMaker training jobs and APIs that create Amazon SageMaker endpoints use this role to access training data and model artifacts. After the endpoint is created, the inference code might use the IAM role, if it needs to access an AWS resource.
  • instance_count (int or PipelineVariable) – Number of Amazon EC2 instances to use for training. Required if instance_groups is not set.

The SDK must be doing some compile time verification over the role (existence etc.) that prevents it from accepting a pipeline parameter.

How would this feature be used? Please describe.

Some users are interested to use SageMaker pipelines for a multi-tenant application. As part of their solution they want to execute a SageMaker pipeline estimator for every tenant with a dedicated IAM role (i.e., the estimator only has access to a tenant-dedicated S3 bucket).

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@navaj0 navaj0 added type: feature request component: pipelines Relates to the SageMaker Pipeline Platform labels Oct 13, 2022
@ivannotes
Copy link
Contributor

+1 to that request.

I have similar requirement. when I dump the pipeline definition, the estimator will always expand the role, in the case a role is a pipeline parameter it will raise error.

It will be great if the estimator can accept role as a pipeline parameter.

@qidewenwhen
Copy link
Member

qidewenwhen commented Jan 27, 2023

Thanks so much for @francescoalongi to work on #3605 to fill in another gap on Processor regarding parameterized role

@ShwetaSingh801
Copy link
Collaborator

Hi @navaj0,

Thanks for using SageMaker and taking the time to suggest ways to improve SageMaker Python SDK. We have added your feature request it to our backlog of feature requests and may consider putting it into future SDK versions. I will go ahead and close the issue now, please let me know if you have any more feedback. Let me know if you have any other questions.

Best,
Shweta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pipelines Relates to the SageMaker Pipeline Platform type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants