Use specified output_kms_key when packaging code with FrameworkProcessor #3390

szamarin · 2022-10-03T20:48:33Z

Issue # 3389

Description of changes:
The FrameworkProcessor uses an underlying estimator_cls to package and upload the user's code. The method which creates the estimator does not provide the output_kms_key to the constructor. As a result the sourcedir.tar.gz is uploaded using the default KMS rather than the user's specified key. I added an additional argument to the estimator constructor to make sure that the specified KMS key is used

vikas0203

/bot run all

sagemaker-bot · 2022-10-19T20:26:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4132632
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T21:06:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4132632
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T21:22:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4132632
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T21:29:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4132632
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-20T00:21:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4132632
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run unit-tests

sagemaker-bot · 2022-11-17T18:53:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4132632
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-11-17T20:33:17Z

Codecov Report

Merging #3390 (7c1f8ee) into master (df701c3) will decrease coverage by 0.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3390      +/-   ##
==========================================
- Coverage   89.55%   88.76%   -0.80%     
==========================================
  Files         960      226     -734     
  Lines       88796    21958   -66838     
==========================================
- Hits        79523    19490   -60033     
+ Misses       9273     2468    -6805

Impacted Files	Coverage Δ
src/sagemaker/processing.py	`94.25% <ø> (ø)`
...lib/python3.7/site-packages/sagemaker/estimator.py
...b/python3.9/site-packages/sagemaker/transformer.py
...10/site-packages/sagemaker/workflow/automl_step.py
...hon3.8/site-packages/sagemaker/lineage/artifact.py
...7/lib/python3.7/site-packages/sagemaker/clarify.py
...hon3.8/site-packages/sagemaker/workflow/airflow.py
...3.10/site-packages/sagemaker/workflow/fail_step.py
...ython3.8/site-packages/sagemaker/workflow/steps.py
...ython3.10/site-packages/sagemaker/pytorch/model.py
... and 1177 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vikas0203

/bot run all

sagemaker-bot · 2022-11-24T05:42:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 346e6b9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T06:14:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 346e6b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T06:18:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 346e6b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T06:36:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 346e6b9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-24T06:41:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 346e6b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run slow-tests

sagemaker-bot · 2022-11-29T23:19:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 346e6b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run all

vikas0203

/bot run slow-tests

…aws#3438) Co-authored-by: Keshav Chandak <[email protected]>

sagemaker-bot · 2022-12-02T22:22:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1d3d8a6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Navin Soni <[email protected]>

…s_key when uploading sourcedir.tar.gz

vikas0203

/bot run all

sagemaker-bot · 2022-12-03T00:02:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b7a84fc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-03T00:17:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b7a84fc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-03T00:24:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b7a84fc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-03T00:25:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b7a84fc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-03T00:46:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b7a84fc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203

/bot run pr

sagemaker-bot · 2022-12-05T18:17:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b7a84fc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203 · 2022-12-20T03:47:22Z

@szamarin , Could you please check and resolve the merge conflicts.

imor-de · 2023-02-17T12:36:52Z

Hello, what is the status of this PR?

vikas0203

/bot run all

sagemaker-bot · 2023-02-21T18:49:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7c1f8ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-21T18:52:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7c1f8ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-21T19:15:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7c1f8ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-21T19:29:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7c1f8ee
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-21T20:16:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7c1f8ee
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure · 2023-04-27T00:17:02Z

Duplicate of #3784 . Hence Closing this PR.

claytonparnell force-pushed the master branch from 1a468a0 to 4132632 Compare October 19, 2022 17:12

vikas0203 reviewed Oct 19, 2022

View reviewed changes

vikas0203 requested a review from claytonparnell October 19, 2022 20:24

claytonparnell reviewed Nov 17, 2022

View reviewed changes

vikas0203 approved these changes Nov 17, 2022

View reviewed changes

vikas0203 self-requested a review November 17, 2022 18:55

claytonparnell approved these changes Nov 17, 2022

View reviewed changes

claytonparnell removed the request for review from vikas0203 November 17, 2022 19:06

vikas0203 requested review from a team and trajanikant and removed request for a team November 23, 2022 20:15

vikas0203 self-assigned this Nov 23, 2022

vikas0203 reviewed Nov 24, 2022

View reviewed changes

vikas0203 reviewed Nov 28, 2022

View reviewed changes

vikas0203 force-pushed the master branch from 346e6b9 to 1d3d8a6 Compare December 1, 2022 03:47

vikas0203 reviewed Dec 1, 2022

View reviewed changes

feature: Update TF 2.9 and TF 2.10 inference DLCs (aws#3465)

76f7782

vikas0203 reviewed Dec 2, 2022

View reviewed changes

keshav-chandak and others added 2 commits December 2, 2022 14:11

feature: Added transform with monitoring pipeline step in transformer (…

fde0738

…aws#3438) Co-authored-by: Keshav Chandak <[email protected]>

fix: Fix bug forcing uploaded tar to be named sourcedir (aws#3412)

7f9f3b0

navinsoni and others added 3 commits December 2, 2022 14:32

feature: Add Code Owners file (aws#3503)

5d59767

Co-authored-by: Navin Soni <[email protected]>

fixed issue with FrameworkProcessor not using the specified output_km…

0d35b2a

…s_key when uploading sourcedir.tar.gz

fixed issue with FrameworkProcessor not using the specified output_km…

b7a84fc

…s_key when uploading sourcedir.tar.gz

vikas0203 force-pushed the master branch from 1d3d8a6 to b7a84fc Compare December 2, 2022 23:39

vikas0203 requested a review from a team as a code owner December 2, 2022 23:39

vikas0203 reviewed Dec 2, 2022

View reviewed changes

vikas0203 reviewed Dec 5, 2022

View reviewed changes

mufaddal-rohawala force-pushed the master branch from bae3b8b to d000bdc Compare December 20, 2022 00:31

Merge branch 'master' into master

7c1f8ee

vikas0203 reviewed Feb 21, 2023

View reviewed changes

knikure closed this Apr 27, 2023

Use specified output_kms_key when packaging code with FrameworkProcessor #3390

Use specified output_kms_key when packaging code with FrameworkProcessor #3390

Conversation

szamarin commented Oct 3, 2022

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 20, 2022

AWS CodeBuild CI Report

claytonparnell left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Nov 17, 2022

AWS CodeBuild CI Report

codecov-commenter commented Nov 17, 2022 • edited Loading

Codecov Report

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 24, 2022

AWS CodeBuild CI Report

vikas0203 left a comment • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented Nov 29, 2022

AWS CodeBuild CI Report

vikas0203 left a comment

Choose a reason for hiding this comment

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Dec 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 3, 2022

AWS CodeBuild CI Report

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

vikas0203 commented Dec 20, 2022

imor-de commented Feb 17, 2023

vikas0203 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

knikure commented Apr 27, 2023

codecov-commenter commented Nov 17, 2022 •

edited

Loading

vikas0203 left a comment •

edited

Loading