Skip to content

fix: add missing Tensorflow 2.9 inference image #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: add missing Tensorflow 2.9 inference image #3251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d53f5d5
fix: add missing Tensorflow 2.9 inference image
plumdog Jul 19, 2022
582d2d5
Attempt a hack to handle missing 2.9.0 training image in tests
plumdog Aug 2, 2022
7e59f82
This is Python, not Typescript
plumdog Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/sagemaker/image_uri_config/tensorflow.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,8 @@
"2.5": "2.5.1",
"2.6": "2.6.3",
"2.7": "2.7.0",
"2.8": "2.8.0"
"2.8": "2.8.0",
"2.9": "2.9.0"
},
"versions": {
"1.10.0": {
Expand Down Expand Up @@ -1468,6 +1469,36 @@
"us-west-2": "763104351884"
},
"repository": "tensorflow-inference"
},
"2.9.0": {
"registries": {
"af-south-1": "626614931356",
"ap-east-1": "871362719292",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
"ap-southeast-2": "763104351884",
"ca-central-1": "763104351884",
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-north-1": "763104351884",
"eu-south-1": "692866216735",
"eu-west-1": "763104351884",
"eu-west-2": "763104351884",
"eu-west-3": "763104351884",
"me-south-1": "217643126080",
"sa-east-1": "763104351884",
"us-east-1": "763104351884",
"us-east-2": "763104351884",
"us-gov-west-1": "442386744353",
"us-iso-east-1": "886529160074",
"us-west-1": "763104351884",
"us-west-2": "763104351884"
},
"repository": "tensorflow-inference"
}
}
},
Expand Down
6 changes: 5 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,12 +408,16 @@ def tf_full_version(tensorflow_training_latest_version, tensorflow_inference_lat
Fixture exists as such, since TF training and TFS have different latest versions.
Otherwise, this would simply be a single latest version.
"""
return str(
version = str(
min(
Version(tensorflow_training_latest_version),
Version(tensorflow_inference_latest_version),
)
)
# Hack. See https://github.com/aws/sagemaker-python-sdk/pull/3251
if version == "2.9.0":
return "2.9"
return version


@pytest.fixture(scope="module")
Expand Down