Skip to content

Use Async Inference Config when available for endpoint update #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2022
+5 −0
Merged

Use Async Inference Config when available for endpoint update #3124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d889212
Use Async Inference Config when available for endpoint update
shreyapandit May 20, 2022
fa91e5e
update default value
shreyapandit May 20, 2022
733aa64
Merge branch 'master' into fix_async_config
navinsoni Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/sagemaker/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3324,6 +3324,11 @@ def create_endpoint_config_from_existing(
if request_data_capture_config_dict is not None:
request["DataCaptureConfig"] = request_data_capture_config_dict

if existing_endpoint_config_desc.get("AsyncInferenceConfig") is not None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please change " existing_endpoint_config_desc.get("AsyncInferenceConfig") " to " existing_endpoint_config_desc.get("AsyncInferenceConfig", None) "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor

@navinsoni navinsoni May 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see it now I meant it on line 3058

request["AsyncInferenceConfig"] = existing_endpoint_config_desc.get(
"AsyncInferenceConfig", None
)

self.sagemaker_client.create_endpoint_config(**request)

def create_endpoint(self, endpoint_name, config_name, tags=None, wait=True):
Expand Down