Use Async Inference Config when available for endpoint update #3124

shreyapandit · 2022-05-20T21:55:41Z

Issue #, if available:

Description of changes:

Endpoint update fails because Async Config is not present

File "src/sagemaker_scripts/deploy_endpoint.py", line 110, in
accelerator_type=args.accelerator_instance,
File "/local/home/andrdodd/Sources/eeyore-amber-cdk/src/EeyoreML/.venv/lib64/python3.7/site-packages/sagemaker/predictor.py", line 307, in update_endpoint
self.endpoint_name, new_endpoint_config_name, wait=wait
File "/local/home/andrdodd/Sources/eeyore-amber-cdk/src/EeyoreML/.venv/lib64/python3.7/site-packages/sagemaker/session.py", line 3084, in update_endpoint
EndpointName=endpoint_name, EndpointConfigName=endpoint_config_name
File "/local/home/andrdodd/Sources/eeyore-amber-cdk/src/EeyoreML/.venv/lib64/python3.7/site-packages/botocore/client.py", line 391, in _api_call
return self._make_api_call(operation_name, kwargs)
File "/local/home/andrdodd/Sources/eeyore-amber-cdk/src/EeyoreML/.venv/lib64/python3.7/site-packages/botocore/client.py", line 719, in _make_api_call
raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (ValidationException) when calling the UpdateEndpoint operation: The AsyncInferenceConfig parameter cannot be removed from this endpoint hescatterplot-2022-05-19-08-06-08-445. To change the endpoint

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2022-05-20T22:19:22Z

Codecov Report

Merging #3124 (8fea9c2) into master (1fa2377) will decrease coverage by 0.21%.
The diff coverage is 88.25%.

❗ Current head 8fea9c2 differs from pull request most recent head 8fc2648. Consider uploading reports for the commit 8fc2648 to get more accurate results

@@            Coverage Diff             @@
##           master    #3124      +/-   ##
==========================================
- Coverage   89.17%   88.96%   -0.22%     
==========================================
  Files         204      212       +8     
  Lines       18979    20437    +1458     
==========================================
+ Hits        16924    18181    +1257     
- Misses       2055     2256     +201

Impacted Files	Coverage Δ
src/sagemaker/feature_store/feature_group.py	`76.52% <ø> (ø)`
src/sagemaker/huggingface/model.py	`89.87% <ø> (ø)`
src/sagemaker/pipeline.py	`85.33% <ø> (ø)`
src/sagemaker/sklearn/model.py	`92.98% <ø> (-1.76%)`	⬇️
...sagemaker/workflow/monitor_batch_transform_step.py	`0.00% <0.00%> (ø)`
src/sagemaker/xgboost/model.py	`96.36% <ø> (-1.82%)`	⬇️
...agemaker/model_monitor/clarify_model_monitoring.py	`89.84% <27.58%> (-5.09%)`	⬇️
src/sagemaker/training_compiler/config.py	`80.43% <60.00%> (-2.90%)`	⬇️
src/sagemaker/pytorch/estimator.py	`94.73% <63.63%> (-5.27%)`	⬇️
src/sagemaker/sklearn/estimator.py	`93.93% <63.63%> (-6.07%)`	⬇️
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-05-20T22:19:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 61dbafa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T22:32:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 61dbafa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T22:43:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 61dbafa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T23:03:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 61dbafa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni · 2022-05-20T23:46:03Z

src/sagemaker/session.py

@@ -3055,6 +3055,11 @@ def create_endpoint_config_from_existing(
        if request_data_capture_config_dict is not None:
            request["DataCaptureConfig"] = request_data_capture_config_dict

+        if existing_endpoint_config_desc.get("AsyncInferenceConfig") is not None:


can you please change " existing_endpoint_config_desc.get("AsyncInferenceConfig") " to " existing_endpoint_config_desc.get("AsyncInferenceConfig", None) "

Oh I see it now I meant it on line 3058

sagemaker-bot · 2022-05-21T00:20:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6dfd75e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-21T00:44:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6dfd75e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-21T00:47:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 61dbafa
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-21T01:03:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6dfd75e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-21T02:45:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6dfd75e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-21T02:48:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6dfd75e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-18T06:53:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a35f36a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-18T07:35:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a35f36a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-18T07:50:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a35f36a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-18T07:54:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a35f36a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-18T09:40:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a35f36a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T17:20:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ab7ff19
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T17:23:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ab7ff19
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T17:47:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ab7ff19
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T18:07:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ab7ff19
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-19T21:37:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ab7ff19
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-16T19:27:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3aa6fe0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-16T19:33:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3aa6fe0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-16T19:33:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3aa6fe0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-16T20:00:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3aa6fe0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-11-16T21:44:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3aa6fe0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni

/bot run all

sagemaker-bot · 2022-12-02T19:54:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8fea9c2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T20:25:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8fea9c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T20:32:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8fea9c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T20:57:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8fea9c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni

/bot run all

sagemaker-bot · 2022-12-02T21:24:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: fa91e5e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T21:25:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: fa91e5e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T21:25:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fa91e5e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T22:28:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: fa91e5e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T22:48:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: fa91e5e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Navin Soni <[email protected]>

navinsoni reviewed May 20, 2022

View reviewed changes

navinsoni approved these changes May 21, 2022

View reviewed changes

mufaddal-rohawala approved these changes Jun 10, 2022

View reviewed changes

claytonparnell force-pushed the fix_async_config branch from a35f36a to ab7ff19 Compare October 19, 2022 17:18

navinsoni self-assigned this Nov 16, 2022

navinsoni force-pushed the fix_async_config branch from ab7ff19 to 3aa6fe0 Compare November 16, 2022 18:49

navinsoni force-pushed the fix_async_config branch from 3aa6fe0 to 8fea9c2 Compare December 1, 2022 22:03

navinsoni approved these changes Dec 2, 2022

View reviewed changes

navinsoni force-pushed the fix_async_config branch from 8fea9c2 to 8fc2648 Compare December 2, 2022 20:24

shreyapandit added 2 commits December 2, 2022 13:22

Use Async Inference Config when available for endpoint update

d889212

update default value

fa91e5e

navinsoni force-pushed the fix_async_config branch from 8fc2648 to fa91e5e Compare December 2, 2022 21:22

navinsoni reviewed Dec 2, 2022

View reviewed changes

Merge branch 'master' into fix_async_config

733aa64

navinsoni requested a review from a team as a code owner December 15, 2022 19:52

navinsoni requested review from trajanikant and removed request for a team December 15, 2022 19:52

navinsoni merged commit 097e829 into aws:master Dec 15, 2022

claytonparnell pushed a commit to claytonparnell/sagemaker-python-sdk that referenced this pull request Dec 16, 2022

Use Async Inference Config when available for endpoint update (aws#3124)

12dc503

Co-authored-by: Navin Soni <[email protected]>

mufaddal-rohawala pushed a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Dec 19, 2022

Use Async Inference Config when available for endpoint update (aws#3124)

06ae740

Co-authored-by: Navin Soni <[email protected]>

mufaddal-rohawala pushed a commit that referenced this pull request Dec 20, 2022

Use Async Inference Config when available for endpoint update (#3124)

2523e46

Co-authored-by: Navin Soni <[email protected]>

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

Use Async Inference Config when available for endpoint update (aws#3124)

e81161e

Co-authored-by: Navin Soni <[email protected]>

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

Use Async Inference Config when available for endpoint update (aws#3124)

1aa3f65

Co-authored-by: Navin Soni <[email protected]>

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

Use Async Inference Config when available for endpoint update (aws#3124)

5f240eb

Co-authored-by: Navin Soni <[email protected]>

Use Async Inference Config when available for endpoint update #3124

Use Async Inference Config when available for endpoint update #3124

Conversation

shreyapandit commented May 20, 2022

Merge Checklist

General

Tests

codecov-commenter commented May 20, 2022 • edited Loading

Codecov Report

sagemaker-bot commented May 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 20, 2022

AWS CodeBuild CI Report

navinsoni May 20, 2022

Choose a reason for hiding this comment

shreyapandit May 20, 2022

Choose a reason for hiding this comment

navinsoni May 21, 2022 • edited Loading

Choose a reason for hiding this comment

sagemaker-bot commented May 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Aug 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Aug 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Aug 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Aug 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Aug 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Oct 19, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Nov 16, 2022

AWS CodeBuild CI Report

navinsoni left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

navinsoni left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2022

codecov-commenter commented May 20, 2022 •

edited

Loading

navinsoni May 21, 2022 •

edited

Loading