Deprecate enable_cloudwatch_metrics from Frameworks #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 92.93% 92.93% +<.01%
==========================================
Files 51 51
Lines 3552 3555 +3
==========================================
+ Hits 3301 3304 +3
Misses 251 251
Continue to review full report at Codecov.
|
andremoeller
suggested changes
Jul 15, 2018
src/sagemaker/estimator.py
Outdated
| @@ -521,7 +521,9 @@ def __init__(self, entry_point, source_dir=None, hyperparameters=None, enable_cl | |||
| super(Framework, self).__init__(**kwargs) | |||
| self.source_dir = source_dir | |||
| self.entry_point = entry_point | |||
| self.enable_cloudwatch_metrics = enable_cloudwatch_metrics | |||
| if enable_cloudwatch_metrics: | |||
| logging.warn('enable_cloudwatch_metrics is now deprecated and will be removed in the future.') | |||
There was a problem hiding this comment.
Could you use warnings.warn instead, with a DeprecationWarning?
https://docs.python.org/3/library/warnings.html#warnings.warn
added 3 commits
July 19, 2018 18:20
There is a warning message for now, but it will be removed later.
iquintero
force-pushed
the
remove_cw_metrics_arg
branch
from
eb1c5ac to
9967d52
Compare
andremoeller
previously approved these changes
Jul 20, 2018
andremoeller
previously approved these changes
Jul 23, 2018
laurenyu
approved these changes
Aug 16, 2018
nadiaya
approved these changes
Aug 16, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
There is a warning message for now, but it will be removed later.
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Add Chainer hyperparameter tuning notebook
knakad
added a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Dec 4, 2019
knakad
added a commit
that referenced
this pull request
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a warning message for now, but it will be removed later.
*Issue #276
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.