Skip to content

fix: HuggingFace image_uri generation for inference #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2021
Merged

fix: HuggingFace image_uri generation for inference #2730

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec9ecee
remove container_version
ahsan-z-khan Oct 25, 2021
b4e7017
Merge branch 'master' into HF-image-uri
ahsan-z-khan Oct 25, 2021
1b50306
Merge branch 'master' into HF-image-uri
ahsan-z-khan Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/sagemaker/huggingface/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,6 @@ def serving_image_uri(self, region_name, instance_type, accelerator_type=None):
str: The appropriate image URI based on the given parameters.

"""
if image_uris._processor(instance_type, ["cpu", "gpu"]) == "gpu":
container_version = "cu110-ubuntu18.04"
else:
container_version = "ubuntu18.04"
if self.tensorflow_version is not None: # pylint: disable=no-member
base_framework_version = (
f"tensorflow{self.tensorflow_version}" # pylint: disable=no-member
Expand All @@ -312,5 +308,4 @@ def serving_image_uri(self, region_name, instance_type, accelerator_type=None):
accelerator_type=accelerator_type,
image_scope="inference",
base_framework_version=base_framework_version,
container_version=container_version,
)